2019-06-06 22:38:32

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the imx-mxs tree

Hi all,

In commit

f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to audio_pll2_out")

Fixes tag

Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for imx8mm")

has these problem(s):

- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-06-07 00:54:53

by Shawn Guo

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree

On Fri, Jun 07, 2019 at 07:46:52AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to audio_pll2_out")
>
> Fixes tag
>
> Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for imx8mm")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").

Hi Stephen,

Thanks for reporting. I just got it fixed, will be more careful about
that in the future.

@Peng, please check your git configuration as suggested above, thanks.

Shawn

2019-06-11 08:38:08

by Peng Fan

[permalink] [raw]
Subject: RE: linux-next: Fixes tag needs some work in the imx-mxs tree

Hi Shawn, Stephen
> Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree
>
> On Fri, Jun 07, 2019 at 07:46:52AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to
> > audio_pll2_out")
> >
> > Fixes tag
> >
> > Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for imx8mm")
> >
> > has these problem(s):
> >
> > - SHA1 should be at least 12 digits long
> > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > or later) just making sure it is not set (or set to "auto").
>
> Hi Stephen,
>
> Thanks for reporting. I just got it fixed, will be more careful about that in the
> future.
>
> @Peng, please check your git configuration as suggested above, thanks.

Sorry for this. Do I need to resend the patch?

Thanks,
Peng.

>
> Shawn

2019-06-12 14:52:36

by Shawn Guo

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree

On Tue, Jun 11, 2019 at 08:36:52AM +0000, Peng Fan wrote:
> Hi Shawn, Stephen
> > Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree
> >
> > On Fri, Jun 07, 2019 at 07:46:52AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > In commit
> > >
> > > f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to
> > > audio_pll2_out")
> > >
> > > Fixes tag
> > >
> > > Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for imx8mm")
> > >
> > > has these problem(s):
> > >
> > > - SHA1 should be at least 12 digits long
> > > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > > or later) just making sure it is not set (or set to "auto").
> >
> > Hi Stephen,
> >
> > Thanks for reporting. I just got it fixed, will be more careful about that in the
> > future.
> >
> > @Peng, please check your git configuration as suggested above, thanks.
>
> Sorry for this. Do I need to resend the patch?

No. I have fixed it on my branch.

Shawn

2019-06-12 17:13:37

by Peng Fan

[permalink] [raw]
Subject: RE: linux-next: Fixes tag needs some work in the imx-mxs tree



> Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree
>
> On Tue, Jun 11, 2019 at 08:36:52AM +0000, Peng Fan wrote:
> > Hi Shawn, Stephen
> > > Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs
> > > tree
> > >
> > > On Fri, Jun 07, 2019 at 07:46:52AM +1000, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > In commit
> > > >
> > > > f6a8ff82ce68 ("clk: imx: imx8mm: correct audio_pll2_clk to
> > > > audio_pll2_out")
> > > >
> > > > Fixes tag
> > > >
> > > > Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for
> > > > imx8mm")
> > > >
> > > > has these problem(s):
> > > >
> > > > - SHA1 should be at least 12 digits long
> > > > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > > > or later) just making sure it is not set (or set to "auto").
> > >
> > > Hi Stephen,
> > >
> > > Thanks for reporting. I just got it fixed, will be more careful
> > > about that in the future.
> > >
> > > @Peng, please check your git configuration as suggested above, thanks.
> >
> > Sorry for this. Do I need to resend the patch?
>
> No. I have fixed it on my branch.

Thanks. I'll take care in future.

Thanks,
Peng.

>
> Shawn