2021-04-07 00:19:33

by Clark Wang

Subject: [PATCH V2 03/18] ARM: dts: imx7ulp: add the missing lpi2c ipg clock

The lpi2c driver has add the missing ipg clock.
So add the ipg clock here for all lpi2c nodes.

Signed-off-by: Clark Wang <[email protected]>
---
V2 changes:
- New patch added in V2
---
arch/arm/boot/dts/imx7ulp.dtsi | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index b7ea37ad4e55..eb0d4b8f624d 100644
--- a/arch/arm/boot/dts/imx7ulp.dtsi
+++ b/arch/arm/boot/dts/imx7ulp.dtsi
@@ -328,8 +328,9 @@ lpi2c6: i2c@40a40000 {
compatible = "fsl,imx7ulp-lpi2c";
reg = <0x40a40000 0x10000>;
interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>;
- clock-names = "ipg";
+ clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>,
+ <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>;
+ clock-names = "per", "ipg";
assigned-clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>;
assigned-clock-parents = <&scg1 IMX7ULP_CLK_FIRC>;
assigned-clock-rates = <48000000>;
@@ -340,8 +341,9 @@ lpi2c7: i2c@40a50000 {
compatible = "fsl,imx7ulp-lpi2c";
reg = <0x40a50000 0x10000>;
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>;
- clock-names = "ipg";
+ clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>,
+ <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>;
+ clock-names = "per", "ipg";
assigned-clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>;
assigned-clock-parents = <&scg1 IMX7ULP_CLK_FIRC>;
assigned-clock-rates = <48000000>;
--
2.25.1

2021-05-21 09:53:03

by Aisheng Dong

Subject: RE: [PATCH V2 03/18] ARM: dts: imx7ulp: add the missing lpi2c ipg clock

> From: Clark Wang <[email protected]>
> Sent: Tuesday, April 6, 2021 7:33 PM
>
> The lpi2c driver has add the missing ipg clock.

Pls drop this line as binding is not decided by driver

> So add the ipg clock here for all lpi2c nodes.

Per clock?

Maybe better refined as add the missing per clock ....

>
> Signed-off-by: Clark Wang <[email protected]>
> ---
> V2 changes:
> - New patch added in V2
> ---
> arch/arm/boot/dts/imx7ulp.dtsi | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
> index b7ea37ad4e55..eb0d4b8f624d 100644
> --- a/arch/arm/boot/dts/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> @@ -328,8 +328,9 @@ lpi2c6: i2c@40a40000 {
> compatible = "fsl,imx7ulp-lpi2c";
> reg = <0x40a40000 0x10000>;
> interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>;
> - clock-names = "ipg";
> + clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>,
> + <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>;
> + clock-names = "per", "ipg";
> assigned-clocks = <&pcc3 IMX7ULP_CLK_LPI2C6>;
> assigned-clock-parents = <&scg1 IMX7ULP_CLK_FIRC>;
> assigned-clock-rates = <48000000>;
> @@ -340,8 +341,9 @@ lpi2c7: i2c@40a50000 {
> compatible = "fsl,imx7ulp-lpi2c";
> reg = <0x40a50000 0x10000>;
> interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>;
> - clock-names = "ipg";
> + clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>,
> + <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>;
> + clock-names = "per", "ipg";
> assigned-clocks = <&pcc3 IMX7ULP_CLK_LPI2C7>;
> assigned-clock-parents = <&scg1 IMX7ULP_CLK_FIRC>;
> assigned-clock-rates = <48000000>;
> --
> 2.25.1