Hi Felix,
On 13 June 2019 14:02, Felix Riemann wrote:
> Subject: [PATCH] regulator: da9062: Adjust LDO voltage selection minimum value
>
> According to the datasheet the LDO's voltage selection registers have
> a minimum value of 0x2. This offset was not observed by the driver,
> causing the LDO output being two steps (= 0.1V) lower than requested.
>
> Signed-off-by: Felix Riemann <[email protected]>
Uh.
That looks right. But I want to take a closer look tomorrow along with my
tests, which must pass this behaviour.
Give me a day or two please.
Regards,
Steve
Hi Steve,
A colleague told me that he saw our mail server mix-up whitespaces in text mails before, although the copy that got relayed back to me looks okay. Is the patch usable or should I try to resend it through another server?
Regards,
Felix
-----Ursprüngliche Nachricht-----
Von: Steve Twiss <[email protected]>
Gesendet: Donnerstag, 13. Juni 2019 16:00
An: Felix Riemann <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected]; Support Opensource <[email protected]>
Betreff: RE: [PATCH] regulator: da9062: Adjust LDO voltage selection minimum value
Hi Felix,
On 13 June 2019 14:02, Felix Riemann wrote:
> Subject: [PATCH] regulator: da9062: Adjust LDO voltage selection
> minimum value
>
> According to the datasheet the LDO's voltage selection registers have
> a minimum value of 0x2. This offset was not observed by the driver,
> causing the LDO output being two steps (= 0.1V) lower than requested.
>
> Signed-off-by: Felix Riemann <[email protected]>
Uh.
That looks right. But I want to take a closer look tomorrow along with my tests, which must pass this behaviour.
Give me a day or two please.
Regards,
Steve
___________________________________________________
SMA Solar Technology AG
Aufsichtsrat: Dr. Erik Ehrentraut (Vorsitzender)
Vorstand: Ulrich Hadding, Dr.-Ing. Juergen Reinert
Handelsregister: Amtsgericht Kassel HRB 3972
Sitz der Gesellschaft: 34266 Niestetal
USt-ID-Nr. DE 113 08 59 54
WEEE-Reg.-Nr. DE 95881150
___________________________________________________
Hi Felix,
On 18 June 2019 12:08 Felix Riemann wrote:
> Subject: AW: [PATCH] regulator: da9062: Adjust LDO voltage selection minimum value
>
> Hi Steve,
>
> A colleague told me that he saw our mail server mix-up whitespaces in text mails
> before, although the copy that got relayed back to me looks okay. Is the patch
> usable or should I try to resend it through another server?
Yes there is a little bit of a white-space mix-up in both patches -- but I could see what
was supposed to happen.
I fixed those this morning and I've made a couple of suggestions. But before I send the
patch back (for your approval) I am just making some changes to my tests so it picks up
this change in future.
No need to send it again, thank you.
Once I've made certain it does what it is supposed to do, I will send for your review.
Regards,
Steve