2019-06-07 20:04:55

by Nick Terrell

[permalink] [raw]
Subject: Re: [RESEND PATCH v2 0/2] Add support for ZSTD-compressed kernel

> On Jun 5, 2019, at 7:43 AM, René Rebe <[email protected]> wrote:
>
> Hey there,
>
> just wanted to check about the status of zstd-compressed kernel.
> It works great for us, and the initrd part I tested on PPC, PPC64, SPARC64,
> HPPA, MIPS64 and probably other random things that I may forgot about in the
> meantime.
>
> Would be great if something like this could be mainlined.

We'd love to get this mainlined as well!

We're using these patches internally as well. We're seeing an improvement on an
Intel Atom N3710, where boot time is reduced by one second over using an xz
compressed kernel. It looks like Ubuntu just switched to a lz4 compressed kernel,
but zstd is likely a better trade off, because it compresses much better and still has
excellent decompression speed.

Since its been nearly a year since I sent these out, I will take some time to rebase
and retest the patches in case anything changed, and then then resend the patches
in the next weeks.

Nick

> [...]


2019-06-07 23:16:07

by Adam Borowski

[permalink] [raw]
Subject: Re: [RESEND PATCH v2 0/2] Add support for ZSTD-compressed kernel

On Fri, Jun 07, 2019 at 07:20:46PM +0000, Nick Terrell wrote:
> We'd love to get this mainlined as well!
>
> We're using these patches internally as well. We're seeing an improvement on an
> Intel Atom N3710, where boot time is reduced by one second over using an xz
> compressed kernel. It looks like Ubuntu just switched to a lz4 compressed kernel,
> but zstd is likely a better trade off, because it compresses much better and still has
> excellent decompression speed.
>
> Since its been nearly a year since I sent these out, I will take some time to rebase
> and retest the patches in case anything changed, and then then resend the patches
> in the next weeks.

Hi!
After the ping, I intended to resend the patch-set (with removals included)
after I return from miniDebconf Hamburg, but you 1. are the author of the
non-trivial part, 2. you have a better test machinery, and 3. I have a
deeply seated preference for effort to be done by people who are not me.

A rebased and working version is at https://github.com/kilobyte/linux/tree/nobz2-v3
but there are no real improvements beyond rebases, a typo fix, and Paul Burton's
ACK for mips.

There's an unaddressed comment by Ingo Molnar
https://lore.kernel.org/lkml/[email protected]/
for your part of the code.

So what do you suggest?


Meow!
--
⢀⣴⠾⠻⢶⣦⠀ Latin: meow 4 characters, 4 columns, 4 bytes
⣾⠁⢠⠒⠀⣿⡁ Greek: μεου 4 characters, 4 columns, 8 bytes
⢿⡄⠘⠷⠚⠋ Runes: ᛗᛖᛟᚹ 4 characters, 4 columns, 12 bytes
⠈⠳⣄⠀⠀⠀⠀ Chinese: 喵 1 character, 2 columns, 3 bytes <-- best!

2019-06-10 18:42:22

by Nick Terrell

[permalink] [raw]
Subject: Re: [RESEND PATCH v2 0/2] Add support for ZSTD-compressed kernel



> On Jun 7, 2019, at 4:06 PM, Adam Borowski <[email protected]> wrote:
>
> On Fri, Jun 07, 2019 at 07:20:46PM +0000, Nick Terrell wrote:
>> We'd love to get this mainlined as well!
>>
>> We're using these patches internally as well. We're seeing an improvement on an
>> Intel Atom N3710, where boot time is reduced by one second over using an xz
>> compressed kernel. It looks like Ubuntu just switched to a lz4 compressed kernel,
>> but zstd is likely a better trade off, because it compresses much better and still has
>> excellent decompression speed.
>>
>> Since its been nearly a year since I sent these out, I will take some time to rebase
>> and retest the patches in case anything changed, and then then resend the patches
>> in the next weeks.
>
> Hi!
> After the ping, I intended to resend the patch-set (with removals included)
> after I return from miniDebconf Hamburg, but you 1. are the author of the
> non-trivial part, 2. you have a better test machinery, and 3. I have a
> deeply seated preference for effort to be done by people who are not me.

If its okay with you I will resend the patch set with your removals included by the end
of next week at the latest. I'll aim for this week.

-Nick

> A rebased and working version is at https://github.com/kilobyte/linux/tree/nobz2-v3
> but there are no real improvements beyond rebases, a typo fix, and Paul Burton's
> ACK for mips.
>
> There's an unaddressed comment by Ingo Molnar
> https://lore.kernel.org/lkml/[email protected]/
> for your part of the code.
>
> So what do you suggest?
>
>
> Meow!
> --
> ⢀⣴⠾⠻⢶⣦⠀ Latin: meow 4 characters, 4 columns, 4 bytes
> ⣾⠁⢠⠒⠀⣿⡁ Greek: μεου 4 characters, 4 columns, 8 bytes
> ⢿⡄⠘⠷⠚⠋ Runes: ᛗᛖᛟᚹ 4 characters, 4 columns, 12 bytes
> ⠈⠳⣄⠀⠀⠀⠀ Chinese: 喵 1 character, 2 columns, 3 bytes <-- best!