2020-07-24 04:15:12

by Chi Song

Subject: [PATCH v8 net-next] net: hyperv: dump TX indirection table to ethtool regs

An imbalanced TX indirection table causes netvsc to have low
performance. This table is created and managed during runtime. To help
better diagnose performance issues caused by imbalanced tables, it needs
make TX indirection tables visible.

Because TX indirection table is driver specified information, so
display it via ethtool register dump.

Signed-off-by: Chi Song <[email protected]>
---
v8: fix corrupt patch file
v7: move to ethtool register dump
v6: update names to be more precise, remove useless assignment
v5: update variable orders
v4: use a separated group to organize tx_indirection better, change
location of attributes init/exit to netvsc_drv_init/exit

drivers/net/hyperv/netvsc_drv.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)

diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 6267f706e8ee..3288221726ea 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -1934,6 +1934,23 @@ static int netvsc_set_features(struct net_device *ndev,
return ret;
}

+static int netvsc_get_regs_len(struct net_device *netdev)
+{
+ return VRSS_SEND_TAB_SIZE * sizeof(u32);
+}
+
+static void netvsc_get_regs(struct net_device *netdev,
+ struct ethtool_regs *regs, void *p)
+{
+ struct net_device_context *ndc = netdev_priv(netdev);
+ u32 *regs_buff = p;
+
+ /* increase the version, if buffer format is changed. */
+ regs->version = 1;
+
+ memcpy(regs_buff, ndc->tx_table, VRSS_SEND_TAB_SIZE * sizeof(u32));
+}
+
static u32 netvsc_get_msglevel(struct net_device *ndev)
{
struct net_device_context *ndev_ctx = netdev_priv(ndev);
@@ -1950,6 +1967,8 @@ static void netvsc_set_msglevel(struct net_device *ndev, u32 val)

static const struct ethtool_ops ethtool_ops = {
.get_drvinfo = netvsc_get_drvinfo,
+ .get_regs_len = netvsc_get_regs_len,
+ .get_regs = netvsc_get_regs,
.get_msglevel = netvsc_get_msglevel,
.set_msglevel = netvsc_set_msglevel,
.get_link = ethtool_op_get_link,
--
2.25.1

2020-07-24 15:29:43

by Haiyang Zhang

Subject: RE: [PATCH v8 net-next] net: hyperv: dump TX indirection table to ethtool regs

> -----Original Message-----
> From: Chi Song <[email protected]>
> Sent: Friday, July 24, 2020 12:14 AM
> To: KY Srinivasan <[email protected]>; Haiyang Zhang
> <[email protected]>; Stephen Hemminger <[email protected]>;
> Wei Liu <[email protected]>; David S. Miller <[email protected]>; Jakub
> Kicinski <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]
> Subject: [PATCH v8 net-next] net: hyperv: dump TX indirection table to ethtool
> regs
>
> An imbalanced TX indirection table causes netvsc to have low
> performance. This table is created and managed during runtime. To help
> better diagnose performance issues caused by imbalanced tables, it needs
> make TX indirection tables visible.
>
> Because TX indirection table is driver specified information, so
> display it via ethtool register dump.
>
> Signed-off-by: Chi Song <[email protected]>

Reviewed-by: Haiyang Zhang <[email protected]>

2020-07-24 22:20:12

by David Miller

Subject: Re: [PATCH v8 net-next] net: hyperv: dump TX indirection table to ethtool regs

From: Chi Song <[email protected]>
Date: Thu, 23 Jul 2020 21:14:26 -0700

> An imbalanced TX indirection table causes netvsc to have low
> performance. This table is created and managed during runtime. To help
> better diagnose performance issues caused by imbalanced tables, it needs
> make TX indirection tables visible.
>
> Because TX indirection table is driver specified information, so
> display it via ethtool register dump.
>
> Signed-off-by: Chi Song <[email protected]>

Applied, thank you.