2018-06-04 13:13:32

by Yue Haibing

Subject: [PATCH net-next] qed: use dma_zalloc_coherent instead of allocator/memset

Use dma_zalloc_coherent instead of dma_alloc_coherent
followed by memset 0.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_cxt.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_cxt.c b/drivers/net/ethernet/qlogic/qed/qed_cxt.c
index 820b226..1835f00 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_cxt.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_cxt.c
@@ -936,14 +936,13 @@ static int qed_cxt_src_t2_alloc(struct qed_hwfn *p_hwfn)
u32 size = min_t(u32, total_size, psz);
void **p_virt = &p_mngr->t2[i].p_virt;

- *p_virt = dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
- size,
- &p_mngr->t2[i].p_phys, GFP_KERNEL);
+ *p_virt = dma_zalloc_coherent(&p_hwfn->cdev->pdev->dev,
+ size, &p_mngr->t2[i].p_phys,
+ GFP_KERNEL);
if (!p_mngr->t2[i].p_virt) {
rc = -ENOMEM;
goto t2_fail;
}
- memset(*p_virt, 0, size);
p_mngr->t2[i].size = size;
total_size -= size;
}
--
2.7.0

2018-06-04 14:55:16

by Tayar, Tomer

Subject: RE: [PATCH net-next] qed: use dma_zalloc_coherent instead of allocator/memset

From: YueHaibing [mailto:[email protected]]
Sent: Monday, June 04, 2018 4:11 PM

> Use dma_zalloc_coherent instead of dma_alloc_coherent
> followed by memset 0.
>
> Signed-off-by: YueHaibing <[email protected]>

Thanks
Acked-by: Tomer Tayar <[email protected]>

2018-06-04 21:29:41

by David Miller

Subject: Re: [PATCH net-next] qed: use dma_zalloc_coherent instead of allocator/memset

From: YueHaibing <[email protected]>
Date: Mon, 4 Jun 2018 21:10:31 +0800

> Use dma_zalloc_coherent instead of dma_alloc_coherent
> followed by memset 0.
>
> Signed-off-by: YueHaibing <[email protected]>

Applied.