2023-01-20 08:52:16

by Nicolin Chen

Subject: [PATCH] selftests: iommu: Fix test_cmd_destroy_access() call in user_copy

The test_cmd_destroy_access() should end with a semicolon, so add one.
There is a test_ioctl_destroy(ioas_id) following already, so drop one.

Fixes: 57f0988706fe ("iommufd: Add a selftest")
Signed-off-by: Nicolin Chen <[email protected]>
---
tools/testing/selftests/iommu/iommufd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selftests/iommu/iommufd.c
index 8aa8a346cf22..fa08209268c4 100644
--- a/tools/testing/selftests/iommu/iommufd.c
+++ b/tools/testing/selftests/iommu/iommufd.c
@@ -1259,7 +1259,7 @@ TEST_F(iommufd_mock_domain, user_copy)

test_cmd_destroy_access_pages(
access_cmd.id, access_cmd.access_pages.out_access_pages_id);
- test_cmd_destroy_access(access_cmd.id) test_ioctl_destroy(ioas_id);
+ test_cmd_destroy_access(access_cmd.id);

test_ioctl_destroy(ioas_id);
}
--
2.39.0

2023-01-20 09:10:12

by Tian, Kevin

Subject: RE: [PATCH] selftests: iommu: Fix test_cmd_destroy_access() call in user_copy

> From: Nicolin Chen <[email protected]>
> Sent: Friday, January 20, 2023 3:42 PM
>
> The test_cmd_destroy_access() should end with a semicolon, so add one.
> There is a test_ioctl_destroy(ioas_id) following already, so drop one.
>
> Fixes: 57f0988706fe ("iommufd: Add a selftest")
> Signed-off-by: Nicolin Chen <[email protected]>

Reviewed-by: Kevin Tian <[email protected]>

2023-01-23 18:30:00

by Jason Gunthorpe

Subject: Re: [PATCH] selftests: iommu: Fix test_cmd_destroy_access() call in user_copy

On Thu, Jan 19, 2023 at 11:42:04PM -0800, Nicolin Chen wrote:
> The test_cmd_destroy_access() should end with a semicolon, so add one.
> There is a test_ioctl_destroy(ioas_id) following already, so drop one.
>
> Fixes: 57f0988706fe ("iommufd: Add a selftest")
> Signed-off-by: Nicolin Chen <[email protected]>
> ---
> tools/testing/selftests/iommu/iommufd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied thanks

Jason