2021-02-03 01:53:19

by Yang Li

Subject: [PATCH] scsi: target: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/target/sbp/sbp_target.c:1009:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/target/sbp/sbp_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
index e4a9b9f..2a6165f 100644
--- a/drivers/target/sbp/sbp_target.c
+++ b/drivers/target/sbp/sbp_target.c
@@ -1006,7 +1006,7 @@ static void tgt_agent_fetch_work(struct work_struct *work)
agent->state = AGENT_STATE_SUSPENDED;

spin_unlock_bh(&agent->lock);
- };
+ }
}

static struct sbp_target_agent *sbp_target_agent_register(
--
1.8.3.1

2021-02-03 02:03:45

by Chaitanya Kulkarni

Subject: Re: [PATCH] scsi: target: remove unneeded semicolon

On 2/2/21 17:52, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/target/sbp/sbp_target.c:1009:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/target/sbp/sbp_target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
> index e4a9b9f..2a6165f 100644
> --- a/drivers/target/sbp/sbp_target.c
> +++ b/drivers/target/sbp/sbp_target.c
> @@ -1006,7 +1006,7 @@ static void tgt_agent_fetch_work(struct work_struct *work)
> agent->state = AGENT_STATE_SUSPENDED;
>
> spin_unlock_bh(&agent->lock);
> - };
> + }
> }
>
> static struct sbp_target_agent *sbp_target_agent_register(
Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>