2019-01-28 15:45:28

by Stefan Agner

Subject: [PATCH] mwifiex: don't print error message on coex event

The BT coex event is not an error condition. Don't print an error
message in this case. The same even in sta_event.c prints a
message using the debug level already.

Signed-off-by: Stefan Agner <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/uap_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/uap_event.c b/drivers/net/wireless/marvell/mwifiex/uap_event.c
index e86217a6b9ca..ca759d9c0253 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_event.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_event.c
@@ -300,7 +300,7 @@ int mwifiex_process_uap_event(struct mwifiex_private *priv)
mwifiex_11h_handle_radar_detected(priv, adapter->event_skb);
break;
case EVENT_BT_COEX_WLAN_PARA_CHANGE:
- dev_err(adapter->dev, "EVENT: BT coex wlan param update\n");
+ mwifiex_dbg(adapter, EVENT, "event: BT coex wlan param update\n");
mwifiex_bt_coex_wlan_param_update_event(priv,
adapter->event_skb);
break;
--
2.20.1

2019-01-29 18:53:36

by Brian Norris

Subject: Re: [PATCH] mwifiex: don't print error message on coex event

On Mon, Jan 28, 2019 at 7:43 AM Stefan Agner <[email protected]> wrote:
>
> The BT coex event is not an error condition. Don't print an error
> message in this case. The same even in sta_event.c prints a
> message using the debug level already.

For some reason, that one (and a handful of others) uses dev_dbg()
instead of mwifiex_dbg() with an appropriate mask (e.g., EVENT). But
mwifiex_dbg() seems preferable for consistency.

> Signed-off-by: Stefan Agner <[email protected]>

Reviewed-by: Brian Norris <[email protected]>

> ---
> drivers/net/wireless/marvell/mwifiex/uap_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/uap_event.c b/drivers/net/wireless/marvell/mwifiex/uap_event.c
> index e86217a6b9ca..ca759d9c0253 100644
> --- a/drivers/net/wireless/marvell/mwifiex/uap_event.c
> +++ b/drivers/net/wireless/marvell/mwifiex/uap_event.c
> @@ -300,7 +300,7 @@ int mwifiex_process_uap_event(struct mwifiex_private *priv)
> mwifiex_11h_handle_radar_detected(priv, adapter->event_skb);
> break;
> case EVENT_BT_COEX_WLAN_PARA_CHANGE:
> - dev_err(adapter->dev, "EVENT: BT coex wlan param update\n");
> + mwifiex_dbg(adapter, EVENT, "event: BT coex wlan param update\n");
> mwifiex_bt_coex_wlan_param_update_event(priv,
> adapter->event_skb);
> break;
> --
> 2.20.1
>

2019-02-08 15:29:55

by Kalle Valo

Subject: Re: [PATCH] mwifiex: don't print error message on coex event

Stefan Agner <[email protected]> wrote:

> The BT coex event is not an error condition. Don't print an error
> message in this case. The same even in sta_event.c prints a
> message using the debug level already.
>
> Signed-off-by: Stefan Agner <[email protected]>
> Reviewed-by: Brian Norris <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

5208fea64e4f mwifiex: don't print error message on coex event

--
https://patchwork.kernel.org/patch/10783935/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches