2021-11-25 07:15:44

by Naresh Kamboju

[permalink] [raw]
Subject: [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared

[ Please ignore this email if it is already reported ]

While building Linux next 20211125 x86 with CONFIG_KASAN=y gcc-11
following warnings / errors noticed.

mm/kasan/shadow.c: In function 'kasan_module_alloc':
mm/kasan/shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared (first
use in this function); did you mean 'VM_DEFER_KMEMLEAK'?
528 | if (vm->flags & VM_DELAY_KMEMLEAK)
| ^~~~~~~~~~~~~~~~~
| VM_DEFER_KMEMLEAK
mm/kasan/shadow.c:528:33: note: each undeclared identifier is reported
only once for each function it appears in
make[3]: *** [scripts/Makefile.build:288: mm/kasan/shadow.o] Error 1

Build config:
https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config


Reported-by: Linux Kernel Functional Testing <[email protected]>

meta data:
-----------
git describe: next-20211125
git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
git_sha: f81e94e91878bded599cc60f2881cfd50991aeb9
git_short_log: f81e94e91878 (\"Add linux-next specific files for 20211125\")
target_arch: x86
toolchain: gcc-11

steps to reproduce:
tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-11
--kconfig defconfig \
--kconfig-add https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config

https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/tuxmake_reproducer.sh

--
Linaro LKFT
https://lkft.linaro.org


2021-11-25 07:35:49

by Kefeng Wang

[permalink] [raw]
Subject: Re: [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared

Sorry for the missing change of VM_DEFER_KMEMLEAK.

I will  add Fixes tag and resend v4.

On 2021/11/25 15:13, Naresh Kamboju wrote:
> [ Please ignore this email if it is already reported ]
>
> While building Linux next 20211125 x86 with CONFIG_KASAN=y gcc-11
> following warnings / errors noticed.
>
> mm/kasan/shadow.c: In function 'kasan_module_alloc':
> mm/kasan/shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared (first
> use in this function); did you mean 'VM_DEFER_KMEMLEAK'?
> 528 | if (vm->flags & VM_DELAY_KMEMLEAK)
> | ^~~~~~~~~~~~~~~~~
> | VM_DEFER_KMEMLEAK
> mm/kasan/shadow.c:528:33: note: each undeclared identifier is reported
> only once for each function it appears in
> make[3]: *** [scripts/Makefile.build:288: mm/kasan/shadow.o] Error 1
>
> Build config:
> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> meta data:
> -----------
> git describe: next-20211125
> git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
> git_sha: f81e94e91878bded599cc60f2881cfd50991aeb9
> git_short_log: f81e94e91878 (\"Add linux-next specific files for 20211125\")
> target_arch: x86
> toolchain: gcc-11
>
> steps to reproduce:
> tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-11
> --kconfig defconfig \
> --kconfig-add https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>
> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/tuxmake_reproducer.sh
>
> --
> Linaro LKFT
> https://lkft.linaro.org
> .

2021-11-25 07:55:23

by Stephen Rothwell

[permalink] [raw]
Subject: Re: [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared

Hi Naresh,

On Thu, 25 Nov 2021 12:43:41 +0530 Naresh Kamboju <[email protected]> wrote:
>
> [ Please ignore this email if it is already reported ]
>
> While building Linux next 20211125 x86 with CONFIG_KASAN=y gcc-11
> following warnings / errors noticed.
>
> mm/kasan/shadow.c: In function 'kasan_module_alloc':
> mm/kasan/shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared (first
> use in this function); did you mean 'VM_DEFER_KMEMLEAK'?
> 528 | if (vm->flags & VM_DELAY_KMEMLEAK)
> | ^~~~~~~~~~~~~~~~~
> | VM_DEFER_KMEMLEAK
> mm/kasan/shadow.c:528:33: note: each undeclared identifier is reported
> only once for each function it appears in
> make[3]: *** [scripts/Makefile.build:288: mm/kasan/shadow.o] Error 1
>
> Build config:
> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> meta data:
> -----------
> git describe: next-20211125
> git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
> git_sha: f81e94e91878bded599cc60f2881cfd50991aeb9
> git_short_log: f81e94e91878 (\"Add linux-next specific files for 20211125\")
> target_arch: x86
> toolchain: gcc-11
>
> steps to reproduce:
> tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-11
> --kconfig defconfig \
> --kconfig-add https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>
> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/tuxmake_reproducer.sh
>
> --
> Linaro LKFT
> https://lkft.linaro.org

Caused by commit

f61bc9ffcab1 ("mm: defer kmemleak object creation of module_alloc()")

from the akpm-current tree. The define is VM_DEFER_KMEMLEAK :-(

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (488.00 B)
OpenPGP digital signature

2021-11-25 08:06:39

by Kefeng Wang

[permalink] [raw]
Subject: Re: [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared


On 2021/11/25 15:53, Stephen Rothwell wrote:
> Hi Naresh,
>
> On Thu, 25 Nov 2021 12:43:41 +0530 Naresh Kamboju <[email protected]> wrote:
>> [ Please ignore this email if it is already reported ]
>>
>> While building Linux next 20211125 x86 with CONFIG_KASAN=y gcc-11
>> following warnings / errors noticed.
>>
>> mm/kasan/shadow.c: In function 'kasan_module_alloc':
>> mm/kasan/shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared (first
>> use in this function); did you mean 'VM_DEFER_KMEMLEAK'?
>> 528 | if (vm->flags & VM_DELAY_KMEMLEAK)
>> | ^~~~~~~~~~~~~~~~~
>> | VM_DEFER_KMEMLEAK
>> mm/kasan/shadow.c:528:33: note: each undeclared identifier is reported
>> only once for each function it appears in
>> make[3]: *** [scripts/Makefile.build:288: mm/kasan/shadow.o] Error 1
>>
>> Build config:
>> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>>
>>
>> Reported-by: Linux Kernel Functional Testing <[email protected]>
>>
>> meta data:
>> -----------
>> git describe: next-20211125
>> git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>> git_sha: f81e94e91878bded599cc60f2881cfd50991aeb9
>> git_short_log: f81e94e91878 (\"Add linux-next specific files for 20211125\")
>> target_arch: x86
>> toolchain: gcc-11
>>
>> steps to reproduce:
>> tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-11
>> --kconfig defconfig \
>> --kconfig-add https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>>
>> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/tuxmake_reproducer.sh
>>
>> --
>> Linaro LKFT
>> https://lkft.linaro.org
> Caused by commit
>
> f61bc9ffcab1 ("mm: defer kmemleak object creation of module_alloc()")
>
> from the akpm-current tree. The define is VM_DEFER_KMEMLEAK :-(
Resend a new one, sorry for missing macro change when v3 version use new
name.
>

2021-11-26 05:09:04

by Stephen Rothwell

[permalink] [raw]
Subject: Re: [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared

Hi all,

On Thu, 25 Nov 2021 15:34:06 +0800 Kefeng Wang <[email protected]> wrote:
>
> Sorry for the missing change of VM_DEFER_KMEMLEAK.
>
> I will  add Fixes tag and resend v4.

I have applied the following patch to linux-next today:

From: Stephen Rothwell <[email protected]>
Date: Fri, 26 Nov 2021 15:34:11 +1100
Subject: [PATCH] mm: kasan: fix VM_DELAY_KMEMLEAK typo

Signed-off-by: Stephen Rothwell <[email protected]>
---
mm/kasan/shadow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c
index 2ade2f484562..94136f84b449 100644
--- a/mm/kasan/shadow.c
+++ b/mm/kasan/shadow.c
@@ -525,7 +525,7 @@ int kasan_module_alloc(void *addr, size_t size, gfp_t gfp_mask)
vm->flags |= VM_KASAN;
kmemleak_ignore(ret);

- if (vm->flags & VM_DELAY_KMEMLEAK)
+ if (vm->flags & VM_DEFER_KMEMLEAK)
kmemleak_vmalloc(vm, size, gfp_mask);

return 0;
--
2.33.0

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (488.00 B)
OpenPGP digital signature