2021-05-24 11:47:52

by Naresh Kamboju

[permalink] [raw]
Subject: x86: unistd_64.h: warning: missing whitespace after the macro name

While building Linux next-20210524 tag with gcc 7.x the following warnings and
errors were noticed.

build log:
------------
HOSTLD scripts/mod/modpost
CC kernel/bounds.s
CALL /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/scripts/atomic/check-atomics.sh
UPD include/generated/bounds.h
UPD include/generated/timeconst.h
CC arch/x86/kernel/asm-offsets.s
In file included from
/srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/arch/x86/include/asm/unistd.h:20:0,
from
/srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/arch/x86/include/asm/seccomp.h:5,
from
/srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/include/linux/seccomp.h:21,
from
/srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/include/linux/sched.h:21,
from
/srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/arch/x86/kernel/asm-offsets.c:10:
./arch/x86/include/generated/uapi/asm/unistd_64.h:4:14: warning:
missing whitespace after the macro name
#define __NR_/usrread 0
^
./arch/x86/include/generated/uapi/asm/unistd_64.h:5:14: warning:
missing whitespace after the macro name
#define __NR_/usrwrite 1
^
./arch/x86/include/generated/uapi/asm/unistd_64.h:5:0: warning:
"__NR_" redefined
#define __NR_/usrwrite 1

./arch/x86/include/generated/uapi/asm/unistd_64.h:4:0: note: this is
the location of the previous definition
#define __NR_/usrread 0

./arch/x86/include/generated/uapi/asm/unistd_64.h:6:14: warning:
missing whitespace after the macro name
#define __NR_/usropen 2
^
./arch/x86/include/generated/uapi/asm/unistd_64.h:6:0: warning:
"__NR_" redefined
#define __NR_/usropen 2

./arch/x86/include/generated/uapi/asm/unistd_64.h:5:0: note: this is
the location of the previous definition
#define __NR_/usrwrite 1

./arch/x86/include/generated/uapi/asm/unistd_64.h:7:14: warning:
missing whitespace after the macro name
#define __NR_/usrclose 3
^
./arch/x86/include/generated/uapi/asm/unistd_64.h:7:0: warning:
"__NR_" redefined
#define __NR_/usrclose 3

./arch/x86/include/generated/uapi/asm/unistd_64.h:6:0: note: this is
the location of the previous definition
#define __NR_/usropen 2

./arch/x86/include/generated/uapi/asm/unistd_64.h:8:14: warning:
missing whitespace after the macro name
#define __NR_/usrstat 4
^
./arch/x86/include/generated/uapi/asm/unistd_64.h:8:0: warning:
"__NR_" redefined
#define __NR_/usrstat 4

./arch/x86/include/generated/uapi/asm/unistd_64.h:7:0: note: this is
the location of the previous definition
#define __NR_/usrclose 3

./arch/x86/include/generated/uapi/asm/unistd_64.h:9:14: warning:
missing whitespace after the macro name
#define __NR_/usrfstat 5
^
./arch/x86/include/generated/uapi/asm/unistd_64.h:9:0: warning:
"__NR_" redefined
#define __NR_/usrfstat 5

./arch/x86/include/generated/uapi/asm/unistd_64.h:8:0: note: this is
the location of the previous definition
#define __NR_/usrstat 4

./arch/x86/include/generated/uapi/asm/unistd_64.h:10:14: warning:
missing whitespace after the macro name
#define __NR_/usrlstat 6
^
./arch/x86/include/generated/uapi/asm/unistd_64.h:10:0: warning:
"__NR_" redefined
#define __NR_/usrlstat 6

./arch/x86/include/generated/uapi/asm/unistd_64.h:9:0: note: this is
the location of the previous definition
#define __NR_/usrfstat 5

<trim>

Reported-by: Naresh Kamboju <[email protected]>

Detailed build link,
https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-next/DISTRO=lkft,MACHINE=intel-corei7-64,label=docker-buster-lkft/1032/console


--
Linaro LKFT
https://lkft.linaro.org


2021-05-25 11:06:31

by Thomas Gleixner

[permalink] [raw]
Subject: Re: x86: unistd_64.h: warning: missing whitespace after the macro name

On Mon, May 24 2021 at 17:16, Naresh Kamboju wrote:

> While building Linux next-20210524 tag with gcc 7.x the following warnings and
> errors were noticed.
>
> build log:
> ------------
> HOSTLD scripts/mod/modpost
> CC kernel/bounds.s
> CALL /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/scripts/atomic/check-atomics.sh
> UPD include/generated/bounds.h
> UPD include/generated/timeconst.h
> CC arch/x86/kernel/asm-offsets.s
> In file included from
> /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/arch/x86/include/asm/unistd.h:20:0,
> from
> /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/arch/x86/include/asm/seccomp.h:5,
> from
> /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/include/linux/seccomp.h:21,
> from
> /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/include/linux/sched.h:21,
> from
> /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/arch/x86/kernel/asm-offsets.c:10:
> ./arch/x86/include/generated/uapi/asm/unistd_64.h:4:14: warning:
> missing whitespace after the macro name
> #define __NR_/usrread 0
> ^

Where is that "/usr" coming from?

Looking at the generator script this looks like a stale $prefix
parameter...

2021-05-25 12:00:33

by Masahiro Yamada

[permalink] [raw]
Subject: Re: x86: unistd_64.h: warning: missing whitespace after the macro name

On Tue, May 25, 2021 at 7:54 PM Thomas Gleixner <[email protected]> wrote:
>
> On Mon, May 24 2021 at 17:16, Naresh Kamboju wrote:
>
> > While building Linux next-20210524 tag with gcc 7.x the following warnings and
> > errors were noticed.
> >
> > build log:
> > ------------
> > HOSTLD scripts/mod/modpost
> > CC kernel/bounds.s
> > CALL /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/scripts/atomic/check-atomics.sh
> > UPD include/generated/bounds.h
> > UPD include/generated/timeconst.h
> > CC arch/x86/kernel/asm-offsets.s
> > In file included from
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/arch/x86/include/asm/unistd.h:20:0,
> > from
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/arch/x86/include/asm/seccomp.h:5,
> > from
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/include/linux/seccomp.h:21,
> > from
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/include/linux/sched.h:21,
> > from
> > /srv/oe/build/tmp-lkft-glibc/work-shared/intel-corei7-64/kernel-source/arch/x86/kernel/asm-offsets.c:10:
> > ./arch/x86/include/generated/uapi/asm/unistd_64.h:4:14: warning:
> > missing whitespace after the macro name
> > #define __NR_/usrread 0
> > ^
>
> Where is that "/usr" coming from?
>
> Looking at the generator script this looks like a stale $prefix
> parameter...


Sorry, it is my mistake.
I submitted a fix.

https://lore.kernel.org/patchwork/patch/1435988/


--
Best Regards
Masahiro Yamada