Signed-off-by: Diego Viola <[email protected]>
---
scripts/kconfig/Makefile | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 9645c07..6da13d0 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -126,7 +126,7 @@ help:
@echo ' config - Update current config utilising a line-oriented program'
@echo ' nconfig - Update current config utilising a ncurses menu based program'
@echo ' menuconfig - Update current config utilising a menu based program'
- @echo ' xconfig - Update current config utilising a QT based front-end'
+ @echo ' xconfig - Update current config utilising a Qt based front-end'
@echo ' gconfig - Update current config utilising a GTK based front-end'
@echo ' oldconfig - Update current config utilising a provided .config as base'
@echo ' localmodconfig - Update current config disabling modules not loaded'
@@ -160,7 +160,7 @@ HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags) \
# mconf: Used for the menuconfig target
# Utilizes the lxdialog package
# qconf: Used for the xconfig target
-# Based on QT which needs to be installed to compile it
+# Based on Qt which needs to be installed to compile it
# gconf: Used for the gconfig target
# Based on GTK which needs to be installed to compile it
# object files used by all kconfig flavours
@@ -219,11 +219,11 @@ ifeq ($(MAKECMDGOALS),xconfig)
$(obj)/.tmp_qtcheck: $(src)/Makefile
-include $(obj)/.tmp_qtcheck
-# QT needs some extra effort...
+# Qt needs some extra effort...
$(obj)/.tmp_qtcheck:
@set -e; echo " CHECK qt"; dir=""; pkg=""; \
if ! pkg-config --exists QtCore 2> /dev/null; then \
- echo "* Unable to find the QT4 tool qmake. Trying to use QT3"; \
+ echo "* Unable to find the Qt4 tool qmake. Trying to use Qt3"; \
pkg-config --exists qt 2> /dev/null && pkg=qt; \
pkg-config --exists qt-mt 2> /dev/null && pkg=qt-mt; \
if [ -n "$$pkg" ]; then \
@@ -237,8 +237,8 @@ $(obj)/.tmp_qtcheck:
done; \
if [ -z "$$dir" ]; then \
echo >&2 "*"; \
- echo >&2 "* Unable to find any QT installation. Please make sure that"; \
- echo >&2 "* the QT4 or QT3 development package is correctly installed and"; \
+ echo >&2 "* Unable to find any Qt installation. Please make sure that"; \
+ echo >&2 "* the Qt4 or Qt3 development package is correctly installed and"; \
echo >&2 "* either qmake can be found or install pkg-config or set"; \
echo >&2 "* the QTDIR environment variable to the correct location."; \
echo >&2 "*"; \
--
2.3.5
Ping?
On Mon, Apr 6, 2015 at 6:27 AM, Diego Viola <[email protected]> wrote:
> Signed-off-by: Diego Viola <[email protected]>
> ---
> scripts/kconfig/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> index 9645c07..6da13d0 100644
> --- a/scripts/kconfig/Makefile
> +++ b/scripts/kconfig/Makefile
> @@ -126,7 +126,7 @@ help:
> @echo ' config - Update current config utilising a line-oriented program'
> @echo ' nconfig - Update current config utilising a ncurses menu based program'
> @echo ' menuconfig - Update current config utilising a menu based program'
> - @echo ' xconfig - Update current config utilising a QT based front-end'
> + @echo ' xconfig - Update current config utilising a Qt based front-end'
> @echo ' gconfig - Update current config utilising a GTK based front-end'
> @echo ' oldconfig - Update current config utilising a provided .config as base'
> @echo ' localmodconfig - Update current config disabling modules not loaded'
> @@ -160,7 +160,7 @@ HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags) \
> # mconf: Used for the menuconfig target
> # Utilizes the lxdialog package
> # qconf: Used for the xconfig target
> -# Based on QT which needs to be installed to compile it
> +# Based on Qt which needs to be installed to compile it
> # gconf: Used for the gconfig target
> # Based on GTK which needs to be installed to compile it
> # object files used by all kconfig flavours
> @@ -219,11 +219,11 @@ ifeq ($(MAKECMDGOALS),xconfig)
> $(obj)/.tmp_qtcheck: $(src)/Makefile
> -include $(obj)/.tmp_qtcheck
>
> -# QT needs some extra effort...
> +# Qt needs some extra effort...
> $(obj)/.tmp_qtcheck:
> @set -e; echo " CHECK qt"; dir=""; pkg=""; \
> if ! pkg-config --exists QtCore 2> /dev/null; then \
> - echo "* Unable to find the QT4 tool qmake. Trying to use QT3"; \
> + echo "* Unable to find the Qt4 tool qmake. Trying to use Qt3"; \
> pkg-config --exists qt 2> /dev/null && pkg=qt; \
> pkg-config --exists qt-mt 2> /dev/null && pkg=qt-mt; \
> if [ -n "$$pkg" ]; then \
> @@ -237,8 +237,8 @@ $(obj)/.tmp_qtcheck:
> done; \
> if [ -z "$$dir" ]; then \
> echo >&2 "*"; \
> - echo >&2 "* Unable to find any QT installation. Please make sure that"; \
> - echo >&2 "* the QT4 or QT3 development package is correctly installed and"; \
> + echo >&2 "* Unable to find any Qt installation. Please make sure that"; \
> + echo >&2 "* the Qt4 or Qt3 development package is correctly installed and"; \
> echo >&2 "* either qmake can be found or install pkg-config or set"; \
> echo >&2 "* the QTDIR environment variable to the correct location."; \
> echo >&2 "*"; \
> --
> 2.3.5
>
Ping?
On Sun, Apr 12, 2015 at 10:22 PM, Diego Viola <[email protected]> wrote:
> Ping?
>
> On Mon, Apr 6, 2015 at 6:27 AM, Diego Viola <[email protected]> wrote:
>> Signed-off-by: Diego Viola <[email protected]>
>> ---
>> scripts/kconfig/Makefile | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
>> index 9645c07..6da13d0 100644
>> --- a/scripts/kconfig/Makefile
>> +++ b/scripts/kconfig/Makefile
>> @@ -126,7 +126,7 @@ help:
>> @echo ' config - Update current config utilising a line-oriented program'
>> @echo ' nconfig - Update current config utilising a ncurses menu based program'
>> @echo ' menuconfig - Update current config utilising a menu based program'
>> - @echo ' xconfig - Update current config utilising a QT based front-end'
>> + @echo ' xconfig - Update current config utilising a Qt based front-end'
>> @echo ' gconfig - Update current config utilising a GTK based front-end'
>> @echo ' oldconfig - Update current config utilising a provided .config as base'
>> @echo ' localmodconfig - Update current config disabling modules not loaded'
>> @@ -160,7 +160,7 @@ HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags) \
>> # mconf: Used for the menuconfig target
>> # Utilizes the lxdialog package
>> # qconf: Used for the xconfig target
>> -# Based on QT which needs to be installed to compile it
>> +# Based on Qt which needs to be installed to compile it
>> # gconf: Used for the gconfig target
>> # Based on GTK which needs to be installed to compile it
>> # object files used by all kconfig flavours
>> @@ -219,11 +219,11 @@ ifeq ($(MAKECMDGOALS),xconfig)
>> $(obj)/.tmp_qtcheck: $(src)/Makefile
>> -include $(obj)/.tmp_qtcheck
>>
>> -# QT needs some extra effort...
>> +# Qt needs some extra effort...
>> $(obj)/.tmp_qtcheck:
>> @set -e; echo " CHECK qt"; dir=""; pkg=""; \
>> if ! pkg-config --exists QtCore 2> /dev/null; then \
>> - echo "* Unable to find the QT4 tool qmake. Trying to use QT3"; \
>> + echo "* Unable to find the Qt4 tool qmake. Trying to use Qt3"; \
>> pkg-config --exists qt 2> /dev/null && pkg=qt; \
>> pkg-config --exists qt-mt 2> /dev/null && pkg=qt-mt; \
>> if [ -n "$$pkg" ]; then \
>> @@ -237,8 +237,8 @@ $(obj)/.tmp_qtcheck:
>> done; \
>> if [ -z "$$dir" ]; then \
>> echo >&2 "*"; \
>> - echo >&2 "* Unable to find any QT installation. Please make sure that"; \
>> - echo >&2 "* the QT4 or QT3 development package is correctly installed and"; \
>> + echo >&2 "* Unable to find any Qt installation. Please make sure that"; \
>> + echo >&2 "* the Qt4 or Qt3 development package is correctly installed and"; \
>> echo >&2 "* either qmake can be found or install pkg-config or set"; \
>> echo >&2 "* the QTDIR environment variable to the correct location."; \
>> echo >&2 "*"; \
>> --
>> 2.3.5
>>
On Sun, 2015-04-12 at 22:24 -0300, Diego Viola wrote:
> Ping?
Two pings within minutes?
> On Sun, Apr 12, 2015 at 10:22 PM, Diego Viola <[email protected]> wrote:
> > Ping?
The patch is trivial. Handling trivial patches might take some time.
Please show some patience. And, if MAINTAINERS is to be believed, you
should have put something like "[TRIVIAL]" somewhere in the subject
line. Perhaps that's why Jiri is silent.
(You sent at least three versions of this patch within a week. Why did
you do that? And, no, you shouldn't resend directly with a proper
Subject: line. Wait a week or two first.)
Thanks,
Paul Bolle
I apologize for being impatient, but I sent my first patch a week ago
and then I sent another after a week.
I realize the patch is trivial, but I still want to see it merged
regardless, and this is my first contribution to the mailing list, so
I apologize for any inconvenience.
I thought my patch was being ignored and I didn't want to see it lost
with all the other emails/patches so I thought about resending it.
Should I send it again after a week if this one is ignored?
Thanks,
Diego
On Mon, Apr 13, 2015 at 5:14 AM, Paul Bolle <[email protected]> wrote:
> On Sun, 2015-04-12 at 22:24 -0300, Diego Viola wrote:
>> Ping?
>
> Two pings within minutes?
>
>> On Sun, Apr 12, 2015 at 10:22 PM, Diego Viola <[email protected]> wrote:
>> > Ping?
>
> The patch is trivial. Handling trivial patches might take some time.
> Please show some patience. And, if MAINTAINERS is to be believed, you
> should have put something like "[TRIVIAL]" somewhere in the subject
> line. Perhaps that's why Jiri is silent.
>
> (You sent at least three versions of this patch within a week. Why did
> you do that? And, no, you shouldn't resend directly with a proper
> Subject: line. Wait a week or two first.)
>
> Thanks,
>
>
> Paul Bolle
>
On Wed, 15 Apr 2015, Diego Viola wrote:
> I apologize for being impatient, but I sent my first patch a week ago
> and then I sent another after a week.
>
> I realize the patch is trivial, but I still want to see it merged
> regardless, and this is my first contribution to the mailing list, so
> I apologize for any inconvenience.
>
> I thought my patch was being ignored and I didn't want to see it lost
> with all the other emails/patches so I thought about resending it.
>
> Should I send it again after a week if this one is ignored?
It's very trivial patch indeed, and that's exactly why it's not on the top
of the TODO list of everybody on CC.
Plus we are just now in the middle of merge window, which is exactly the
time when everyone is focusing on merging with Linus, and postpones even
looking at patches which are not urgent bugfixes.
Don't worry about us not seeing your endless stream of pings about this
typo. We are rather good in not losing e-mails, and you are trying really
hard not to be overlooked.
Patience is a virtue.
--
Jiri Kosina
SUSE Labs
Thanks, that gives me hope, I'll wait patiently then.
BTW, if you want any reference for how this is written, see this:
http://en.wikipedia.org/wiki/Qt_%28software%29
Thanks,
Diego
On Wed, Apr 15, 2015 at 2:36 AM, Jiri Kosina <[email protected]> wrote:
> On Wed, 15 Apr 2015, Diego Viola wrote:
>
>> I apologize for being impatient, but I sent my first patch a week ago
>> and then I sent another after a week.
>>
>> I realize the patch is trivial, but I still want to see it merged
>> regardless, and this is my first contribution to the mailing list, so
>> I apologize for any inconvenience.
>>
>> I thought my patch was being ignored and I didn't want to see it lost
>> with all the other emails/patches so I thought about resending it.
>>
>> Should I send it again after a week if this one is ignored?
>
> It's very trivial patch indeed, and that's exactly why it's not on the top
> of the TODO list of everybody on CC.
>
> Plus we are just now in the middle of merge window, which is exactly the
> time when everyone is focusing on merging with Linus, and postpones even
> looking at patches which are not urgent bugfixes.
>
> Don't worry about us not seeing your endless stream of pings about this
> typo. We are rather good in not losing e-mails, and you are trying really
> hard not to be overlooked.
>
> Patience is a virtue.
>
> --
> Jiri Kosina
> SUSE Labs