Hi Michael,
What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
plan to push all your IRQF_DISABLED removal patches in one go ?
On Monday 09 December 2013 11:16:22 Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <[email protected]>
> Acked-by: Lad, Prabhakar <[email protected]>
> ---
> drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c index
> d8ce20d2fbda..cda8388cbb89 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> @@ -298,7 +298,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> {
> int ret = 0;
>
> - ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, IRQF_DISABLED,
> + ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, 0,
> "vpfe_capture0", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> @@ -306,7 +306,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> return ret;
> }
>
> - ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, IRQF_DISABLED,
> + ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, 0,
> "vpfe_capture1", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> @@ -316,7 +316,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> }
>
> ret = request_irq(vpfe_dev->imp_dma_irq, vpfe_imp_dma_isr,
> - IRQF_DISABLED, "Imp_Sdram_Irq", vpfe_dev);
> + 0, "Imp_Sdram_Irq", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> "Error: requesting IMP IRQ interrupt\n");
--
Regards,
Laurent Pinchart
Hi Laurent,
On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
> Hi Michael,
>
> What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
> plan to push all your IRQF_DISABLED removal patches in one go ?
It's true a good number of my patches haven't been picked up yet, even
after multiple resends.
I was planning to ask the community tomorrow about what to do to finally
get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
in one go (or removing the definition of IRQF_DISABLED) may be the final
solution.
I hope to be able to answer your question by the end of the week.
Thanks for getting back to me about this!
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
Hi Michael,
On Thursday 20 February 2014 14:17:09 Michael Opdenacker wrote:
> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
> > Hi Michael,
> >
> > What's the status of this patch ? Do expect Prabhakar to pick it up, or do
> > you plan to push all your IRQF_DISABLED removal patches in one go ?
>
> It's true a good number of my patches haven't been picked up yet, even
> after multiple resends.
Maintainers might have assumed that you would push all the patches yourself.
That might be why Prabhakar has acked your patch but hasn't picked it up.
> I was planning to ask the community tomorrow about what to do to finally
> get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
> in one go (or removing the definition of IRQF_DISABLED) may be the final
> solution.
>
> I hope to be able to answer your question by the end of the week.
>
> Thanks for getting back to me about this!
--
Regards,
Laurent Pinchart
Hi Michael,
On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
<[email protected]> wrote:
> Hi Laurent,
>
> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
>> Hi Michael,
>>
>> What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
>> plan to push all your IRQF_DISABLED removal patches in one go ?
> It's true a good number of my patches haven't been picked up yet, even
> after multiple resends.
>
> I was planning to ask the community tomorrow about what to do to finally
> get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
> in one go (or removing the definition of IRQF_DISABLED) may be the final
> solution.
>
> I hope to be able to answer your question by the end of the week.
>
gentle ping. should I pick it up ?
Regards,
--Prabhakar Lad
Hi Michael,
On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad
<[email protected]> wrote:
> Hi Michael,
>
> On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
> <[email protected]> wrote:
>> Hi Laurent,
>>
>> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
>>> Hi Michael,
>>>
>>> What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
>>> plan to push all your IRQF_DISABLED removal patches in one go ?
>> It's true a good number of my patches haven't been picked up yet, even
>> after multiple resends.
>>
>> I was planning to ask the community tomorrow about what to do to finally
>> get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
>> in one go (or removing the definition of IRQF_DISABLED) may be the final
>> solution.
>>
>> I hope to be able to answer your question by the end of the week.
>>
> gentle ping. should I pick it up ?
>
I've picked it up.
Thanks,
--Prabhakar Lad
Hi Prabhakar
On 02/25/2014 07:02 AM, Prabhakar Lad wrote:
> Hi Michael,
>
> On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad
> <[email protected]> wrote:
>> Hi Michael,
>>
>> On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
>> <[email protected]> wrote:
>>> Hi Laurent,
>>>
>>> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
>>>> Hi Michael,
>>>>
>>>> What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
>>>> plan to push all your IRQF_DISABLED removal patches in one go ?
>>> It's true a good number of my patches haven't been picked up yet, even
>>> after multiple resends.
>>>
>>> I was planning to ask the community tomorrow about what to do to finally
>>> get rid of IRQF_DISABLED. Effectively, pushing all the remaining changes
>>> in one go (or removing the definition of IRQF_DISABLED) may be the final
>>> solution.
>>>
>>> I hope to be able to answer your question by the end of the week.
>>>
>> gentle ping. should I pick it up ?
>>
> I've picked it up.
>
> Thanks,
> --Prabhakar Lad
Thanks a lot! Yes, I was planning to wait for another cycle before
sending a treewide patch.
Cheers,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098