2014-04-02 09:40:21

by Hans Verkuil

Subject: Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer

On 03/24/14 18:51, Lad, Prabhakar wrote:
> From: "Lad, Prabhakar" <[email protected]>
>
> Signed-off-by: Lad, Prabhakar <[email protected]>
> ---
> Documentation/video4linux/v4l2-pci-skeleton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
> index 3a1c0d2..61a56f4 100644
> --- a/Documentation/video4linux/v4l2-pci-skeleton.c
> +++ b/Documentation/video4linux/v4l2-pci-skeleton.c
> @@ -87,7 +87,7 @@ struct skel_buffer {
>
> static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
> {
> - return container_of(vb2, struct skel_buffer, vb);
> + return container_of(vb2, struct skel_buffer, vb2);

Why is this a type? The vb2_buffer member in struct skel_buffer is called
'vb', so this should be correct.

Regards,

Hans

> }
>
> static const struct pci_device_id skeleton_pci_tbl[] = {
>

2014-04-02 10:22:56

by Lad, Prabhakar

Subject: Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer

Hi Hans,

On Wed, Apr 2, 2014 at 3:08 PM, Hans Verkuil <[email protected]> wrote:
> On 03/24/14 18:51, Lad, Prabhakar wrote:
>> From: "Lad, Prabhakar" <[email protected]>
>>
>> Signed-off-by: Lad, Prabhakar <[email protected]>
>> ---
>> Documentation/video4linux/v4l2-pci-skeleton.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
>> index 3a1c0d2..61a56f4 100644
>> --- a/Documentation/video4linux/v4l2-pci-skeleton.c
>> +++ b/Documentation/video4linux/v4l2-pci-skeleton.c
>> @@ -87,7 +87,7 @@ struct skel_buffer {
>>
>> static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
>> {
>> - return container_of(vb2, struct skel_buffer, vb);
>> + return container_of(vb2, struct skel_buffer, vb2);
>
> Why is this a type? The vb2_buffer member in struct skel_buffer is called
> 'vb', so this should be correct.
>
Oops may be I overlooked, sorry for the noise.

Thanks,
--Prabhakar Lad