2019-09-12 13:00:23

by Benoit Parrot

Subject: [Patch 3/6] media: dt-bindings: ov2659: add powerdown-gpios optional property

Add powerdown-gpios to the list of optional properties for the OV2659
camera sensor.

Signed-off-by: Benoit Parrot <[email protected]>
---
Documentation/devicetree/bindings/media/i2c/ov2659.txt | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
index cabc7d827dfb..f55204cce0cd 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov2659.txt
+++ b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
@@ -12,6 +12,10 @@ Required Properties:
- clock-names: should be "xvclk".
- link-frequencies: target pixel clock frequency.

+Optional Properties:
+- powerdown-gpios: reference to the GPIO connected to the pwdn pin, if any.
+ Active is low.
+
For further reading on port node refer to
Documentation/devicetree/bindings/media/video-interfaces.txt.

@@ -27,6 +31,8 @@ Example:
clocks = <&clk_ov2659 0>;
clock-names = "xvclk";

+ powerdown-gpios = <&gpio6 14 GPIO_ACTIVE_LOW>;
+
port {
ov2659_0: endpoint {
remote-endpoint = <&vpfe_ep>;
--
2.17.1

2019-09-14 15:48:59

by Lad, Prabhakar

Subject: Re: [Patch 3/6] media: dt-bindings: ov2659: add powerdown-gpios optional property

Hi Benoit,

Thank you for the patch.

On Thu, Sep 12, 2019 at 1:58 PM Benoit Parrot <[email protected]> wrote:
>
> Add powerdown-gpios to the list of optional properties for the OV2659
> camera sensor.
>
> Signed-off-by: Benoit Parrot <[email protected]>
> ---
> Documentation/devicetree/bindings/media/i2c/ov2659.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
> index cabc7d827dfb..f55204cce0cd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov2659.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
> @@ -12,6 +12,10 @@ Required Properties:
> - clock-names: should be "xvclk".
> - link-frequencies: target pixel clock frequency.
>
> +Optional Properties:
> +- powerdown-gpios: reference to the GPIO connected to the pwdn pin, if any.
> + Active is low.
> +
as per the datasheet this should be active high with pull-down resistor.

Cheers,
--Prabhakar Lad

2019-09-16 01:46:13

by Benoit Parrot

Subject: Re: [Patch 3/6] media: dt-bindings: ov2659: add powerdown-gpios optional property

Lad, Prabhakar <[email protected]> wrote on Sat [2019-Sep-14 11:11:02 +0100]:
> Hi Benoit,
>
> Thank you for the patch.
>
> On Thu, Sep 12, 2019 at 1:58 PM Benoit Parrot <[email protected]> wrote:
> >
> > Add powerdown-gpios to the list of optional properties for the OV2659
> > camera sensor.
> >
> > Signed-off-by: Benoit Parrot <[email protected]>
> > ---
> > Documentation/devicetree/bindings/media/i2c/ov2659.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
> > index cabc7d827dfb..f55204cce0cd 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov2659.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
> > @@ -12,6 +12,10 @@ Required Properties:
> > - clock-names: should be "xvclk".
> > - link-frequencies: target pixel clock frequency.
> >
> > +Optional Properties:
> > +- powerdown-gpios: reference to the GPIO connected to the pwdn pin, if any.
> > + Active is low.
> > +
> as per the datasheet this should be active high with pull-down resistor.

Ahhh, yes I'll fix that.

>
> Cheers,
> --Prabhakar Lad