Hi Michal,
Thanks for the patch.
On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek <[email protected]> wrote:
> Modules can use this function for creating pool.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> I am pushing Zynq OCMC driver which is using this function.
>
> ---
> lib/genalloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
don’t you need to add an entry in include/linux/genalloc.h ?
Thanks,
--Prabhakar Lad
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index cce4dd68c40d..2e65d206b01c 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -598,6 +598,7 @@ struct gen_pool *devm_gen_pool_create(struct device *dev, int min_alloc_order,
>
> return pool;
> }
> +EXPORT_SYMBOL(devm_gen_pool_create);
>
> /**
> * dev_get_gen_pool - Obtain the gen_pool (if any) for a device
> --
> 1.8.2.3
>
On 12/02/2014 10:31 AM, Prabhakar Lad wrote:
> Hi Michal,
>
> Thanks for the patch.
>
> On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek <[email protected]> wrote:
>> Modules can use this function for creating pool.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>> ---
>>
>> I am pushing Zynq OCMC driver which is using this function.
>>
>> ---
>> lib/genalloc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
> don’t you need to add an entry in include/linux/genalloc.h ?
Not sure what exactly you mean. declaration is there.
include/linux/genalloc.h:120:extern struct gen_pool *devm_gen_pool_create(struct device *dev,
And all EXPORT_SYMBOL() are out of headers directly below function
which you want to export.
Can you please clarify what you did mean by that?
Thanks,
Michal
Hi Michal,
On Tue, Dec 2, 2014 at 9:36 AM, Michal Simek <[email protected]> wrote:
> On 12/02/2014 10:31 AM, Prabhakar Lad wrote:
>> Hi Michal,
>>
>> Thanks for the patch.
>>
>> On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek <[email protected]> wrote:
>>> Modules can use this function for creating pool.
>>>
>>> Signed-off-by: Michal Simek <[email protected]>
>>> ---
>>>
>>> I am pushing Zynq OCMC driver which is using this function.
>>>
>>> ---
>>> lib/genalloc.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>> don’t you need to add an entry in include/linux/genalloc.h ?
>
> Not sure what exactly you mean. declaration is there.
> include/linux/genalloc.h:120:extern struct gen_pool *devm_gen_pool_create(struct device *dev,
>
> And all EXPORT_SYMBOL() are out of headers directly below function
> which you want to export.
>
> Can you please clarify what you did mean by that?
>
Oops missed it, since it was a exported function I was expecting a entry
in a header file, but yes the entry exists already so,
Acked-by: Lad, Prabhakar <[email protected]>
Thanks,
--Prabhakar Lad