On Tue, May 31, 2022 at 7:52 PM Andrew Morton <[email protected]> wrote:
>
> On Tue, 31 May 2022 17:43:49 +0200 [email protected] wrote:
>
> > From: Andrey Konovalov <[email protected]>
> >
> > Add a clear_highpage_tagged() helper that does clear_highpage() on a
> > page potentially tagged by KASAN.
>
> clear_highpage_kasan_tagged() would be a better name, no?
Sounds good! Will include into v2.
I also noticed there's an extra empty line at the end of the function
I need to fix.
>
> --- a/include/linux/highmem.h~mm-introduce-clear_highpage_tagged-fix
> +++ a/include/linux/highmem.h
> @@ -243,7 +243,7 @@ static inline void clear_highpage(struct
> kunmap_local(kaddr);
> }
>
> -static inline void clear_highpage_tagged(struct page *page)
> +static inline void clear_highpage_kasan_tagged(struct page *page)
> {
> u8 tag;
>
> --- a/mm/page_alloc.c~mm-introduce-clear_highpage_tagged-fix
> +++ a/mm/page_alloc.c
> @@ -1311,7 +1311,7 @@ static void kernel_init_pages(struct pag
> /* s390's use of memset() could override KASAN redzones. */
> kasan_disable_current();
> for (i = 0; i < numpages; i++)
> - clear_highpage_tagged(page + i);
> + clear_highpage_kasan_tagged(page + i);
> kasan_enable_current();
> }
>
> _
>