2022-05-26 07:33:43

by Andrey Konovalov

[permalink] [raw]
Subject: Re: [PATCH] mm: kasan: Fix input of vmalloc_to_page()

On Wed, May 25, 2022 at 1:58 PM Kefeng Wang <[email protected]> wrote:
>
> When print virtual mapping info for vmalloc address, it should pass
> the addr not page, fix it.
>
> Fixes: c056a364e954 ("kasan: print virtual mapping info in reports")
> Signed-off-by: Kefeng Wang <[email protected]>
> ---
> mm/kasan/report.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index 199d77cce21a..b341a191651d 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -347,7 +347,7 @@ static void print_address_description(void *addr, u8 tag)
> va->addr, va->addr + va->size, va->caller);
> pr_err("\n");
>
> - page = vmalloc_to_page(page);
> + page = vmalloc_to_page(addr);
> }
> }
>
> --
> 2.35.3
>

Nice catch, thanks!

Reviewed-by: Andrey Konovalov <[email protected]>