On Wed, Aug 26, 2020 at 10:14 PM Nick Desaulniers
<[email protected]> wrote:
>
> During Plumbers 2020, we voted to just support the latest release of
> Clang for now. Add a compile time check for this.
Since this effectively enforces a minimum version for Clang, I'd
also update `Documentation/process/changes.rst` and
`Documentation/admin-guide/README.rst` to mention this, and perhaps
use that as a commit title ("implement minimum version for Clang")
since that is the important change, not the implementation so much!
[Actually, I'd remove the particular GCC version from the
`admin-guide/README.rst` to avoid having the version in 2 places (that
doc already links to the other one), but that should be another
patch.]
Reviewed-by: Miguel Ojeda <[email protected]>
Cheers,
Miguel
On Wed, Aug 26, 2020 at 11:17:34PM +0200, Miguel Ojeda wrote:
> On Wed, Aug 26, 2020 at 10:14 PM Nick Desaulniers
> <[email protected]> wrote:
> >
> > During Plumbers 2020, we voted to just support the latest release of
> > Clang for now. Add a compile time check for this.
>
> Since this effectively enforces a minimum version for Clang, I'd
> also update `Documentation/process/changes.rst` and
> `Documentation/admin-guide/README.rst` to mention this, and perhaps
> use that as a commit title ("implement minimum version for Clang")
> since that is the important change, not the implementation so much!
I was actually going to comment on this separately but you beat me to it
:) this patch probably should have been sent as a series with the
Documentation update to avoid confusion for the reviewers:
https://lore.kernel.org/lkml/[email protected]/
Cheers,
Nathan
> [Actually, I'd remove the particular GCC version from the
> `admin-guide/README.rst` to avoid having the version in 2 places (that
> doc already links to the other one), but that should be another
> patch.]
>
> Reviewed-by: Miguel Ojeda <[email protected]>
>
> Cheers,
> Miguel
On Wed, Aug 26, 2020 at 11:26 PM Nathan Chancellor
<[email protected]> wrote:
>
> On Wed, Aug 26, 2020 at 11:17:34PM +0200, Miguel Ojeda wrote:
> > On Wed, Aug 26, 2020 at 10:14 PM Nick Desaulniers
> > <[email protected]> wrote:
> > >
> > > During Plumbers 2020, we voted to just support the latest release of
> > > Clang for now. Add a compile time check for this.
> >
> > Since this effectively enforces a minimum version for Clang, I'd
> > also update `Documentation/process/changes.rst` and
> > `Documentation/admin-guide/README.rst` to mention this, and perhaps
> > use that as a commit title ("implement minimum version for Clang")
> > since that is the important change, not the implementation so much!
>
> I was actually going to comment on this separately but you beat me to it
> :) this patch probably should have been sent as a series with the
> Documentation update to avoid confusion for the reviewers:
>
Agreed... This patch should be combined with the other one and sent as
a patch-series.
- Sedat -
> https://lore.kernel.org/lkml/[email protected]/
>
> Cheers,
> Nathan
>
> > [Actually, I'd remove the particular GCC version from the
> > `admin-guide/README.rst` to avoid having the version in 2 places (that
> > doc already links to the other one), but that should be another
> > patch.]
> >
> > Reviewed-by: Miguel Ojeda <[email protected]>
> >
> > Cheers,
> > Miguel