2023-07-05 11:41:58

by Komal Bajaj

[permalink] [raw]
Subject: [PATCH v2 0/2] arm64: dts: qcom: qdu1000: Update reserved memory region

Update reserved memory region for QDU1000 and QRU1000 SoCs.

Changes in v2:
- Changed the node name.
- Dropped unnecessary properties.

Komal Bajaj (2):
arm64: dts: qcom: qdu1000-idp: Update reserved memory region
arm64: dts: qcom: qru1000-idp: Update reserved memory region

arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 22 ++++++++++++++++++++++
arch/arm64/boot/dts/qcom/qru1000-idp.dts | 12 ++++++++++++
2 files changed, 34 insertions(+)

--
2.40.1



2023-07-05 11:42:04

by Komal Bajaj

[permalink] [raw]
Subject: [PATCH v2 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region

Add missing reserved regions as described in QDU1000 memory map.

Signed-off-by: Komal Bajaj <[email protected]>
---
arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
index 1d22f87fd238..47e5e31dde23 100644
--- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
@@ -448,6 +448,28 @@ &qupv3_id_0 {
status = "okay";
};

+&reserved_memory{
+ ecc_meta_data_mem: memory@e0000000{
+ reg = <0x0 0xe0000000 0x0 0x20000000>;
+ no-map;
+ };
+
+ harq_buffer_mem: memory@800000000{
+ reg = <0x8 0x0 0x0 0x80000000>;
+ no-map;
+ };
+
+ tenx_sp_buffer_mem: memory@880000000{
+ reg = <0x8 0x80000000 0x0 0x50000000>;
+ no-map;
+ };
+
+ fapi_buffer_mem: memory@8d0000000{
+ reg = <0x8 0xd0000000 0x0 0x20000000>;
+ no-map;
+ };
+};
+
&sdhc {
pinctrl-0 = <&sdc_on_state>;
pinctrl-1 = <&sdc_off_state>;
--
2.40.1


2023-07-05 14:33:52

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region

On 05/07/2023 13:06, Komal Bajaj wrote:
> Add missing reserved regions as described in QDU1000 memory map.
>
> Signed-off-by: Komal Bajaj <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> index 1d22f87fd238..47e5e31dde23 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> @@ -448,6 +448,28 @@ &qupv3_id_0 {
> status = "okay";
> };
>
> +&reserved_memory{
> + ecc_meta_data_mem: memory@e0000000{

Missing spaces before '{'. I was correcting this already:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66b14154e278807811d67de9fb0d5cc76638d07b
so it seems I need to keep doing the same.

Anyway, the names should follow purpose, not "memory". See link from Konrad.


Best regards,
Krzysztof


2023-07-05 14:37:46

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region

On Wed, 5 Jul 2023 at 17:24, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 05/07/2023 13:06, Komal Bajaj wrote:
> > Add missing reserved regions as described in QDU1000 memory map.
> >
> > Signed-off-by: Komal Bajaj <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > index 1d22f87fd238..47e5e31dde23 100644
> > --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > @@ -448,6 +448,28 @@ &qupv3_id_0 {
> > status = "okay";
> > };
> >
> > +&reserved_memory{
> > + ecc_meta_data_mem: memory@e0000000{
>
> Missing spaces before '{'. I was correcting this already:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66b14154e278807811d67de9fb0d5cc76638d07b
> so it seems I need to keep doing the same.
>
> Anyway, the names should follow purpose, not "memory". See link from Konrad.

Yes, mea culpa. Please excuse me for the suggestion, I was looking at
the older device tree files.

>
>
> Best regards,
> Krzysztof
>


--
With best wishes
Dmitry

2023-07-06 13:09:43

by Komal Bajaj

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region



On 7/5/2023 7:51 PM, Krzysztof Kozlowski wrote:
> On 05/07/2023 13:06, Komal Bajaj wrote:
>> Add missing reserved regions as described in QDU1000 memory map.
>>
>> Signed-off-by: Komal Bajaj <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> index 1d22f87fd238..47e5e31dde23 100644
>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> @@ -448,6 +448,28 @@ &qupv3_id_0 {
>> status = "okay";
>> };
>>
>> +&reserved_memory{
>> + ecc_meta_data_mem: memory@e0000000{
> Missing spaces before '{'. I was correcting this already:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66b14154e278807811d67de9fb0d5cc76638d07b
> so it seems I need to keep doing the same.
>
> Anyway, the names should follow purpose, not "memory". See link from Konrad.

Sure, will correct it in the next patch set.

>
>
> Best regards,
> Krzysztof
>