2023-03-26 15:59:16

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 01/11] arm64: dts: qcom: sdm845-cheza: use just "port" in Innolux panel

The panel bindings expect to have only one port, thus they do not allow
to use "ports" node:

sdm845-cheza-r2.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index f2b48241d15c..59ad6a8403d2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -135,11 +135,9 @@ panel: panel {
backlight = <&backlight>;
no-hpd;

- ports {
- panel_in: port {
- panel_in_edp: endpoint {
- remote-endpoint = <&sn65dsi86_out>;
- };
+ panel_in: port {
+ panel_in_edp: endpoint {
+ remote-endpoint = <&sn65dsi86_out>;
};
};
};
--
2.34.1


2023-03-26 15:59:17

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 02/11] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: use just "port" in panel

The panel bindings expect to have only one port, thus they do not allow
to use "ports" node:

sc8280xp-lenovo-thinkpad-x13s.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 0e7aa7bd9a2c..27371d4c186e 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -553,11 +553,9 @@ panel {
backlight = <&backlight>;
power-supply = <&vreg_edp_3p3>;

- ports {
- port {
- edp_panel_in: endpoint {
- remote-endpoint = <&mdss0_dp3_out>;
- };
+ port {
+ edp_panel_in: endpoint {
+ remote-endpoint = <&mdss0_dp3_out>;
};
};
};
--
2.34.1

2023-03-26 15:59:18

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 07/11] arm64: dts: qcom: sc7180-qcard: use just "port" in panel

The panel bindings expect to have only one port, thus they do not allow
to use "ports" node:

sc7280-herobrine-zombie-nvme-lte.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
index 95d9e4a19d76..9137db066d9e 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
@@ -354,14 +354,9 @@ edp_panel: panel {

backlight = <&pm8350c_pwm_backlight>;

- ports {
- #address-cells = <1>;
- #size-cells = <0>;
- port@0 {
- reg = <0>;
- edp_panel_in: endpoint {
- remote-endpoint = <&mdss_edp_out>;
- };
+ port {
+ edp_panel_in: endpoint {
+ remote-endpoint = <&mdss_edp_out>;
};
};
};
--
2.34.1

2023-03-26 15:59:27

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 04/11] arm64: dts: qcom: sc7180-idp: use just "port" in panel

The panel bindings expect to have only one port, thus they do not allow
to use "ports" node:

sc7180-idp.dtb: panel@0: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
sc7180-idp.dtb: panel@0: 'port' is a required property

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index c3bdd3295c02..fcabbc6a897f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -312,14 +312,9 @@ panel@0 {

reset-gpios = <&pm6150l_gpios 3 GPIO_ACTIVE_HIGH>;

- ports {
- #address-cells = <1>;
- #size-cells = <0>;
- port@0 {
- reg = <0>;
- panel0_in: endpoint {
- remote-endpoint = <&dsi0_out>;
- };
+ port {
+ panel0_in: endpoint {
+ remote-endpoint = <&dsi0_out>;
};
};
};
--
2.34.1

2023-03-26 15:59:27

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 06/11] arm64: dts: qcom: sc7180-trogdor-wormdingler: use just "port" in panel

The panel bindings expect to have only one port, thus they do not allow
to use "ports" node:

sc7180-trogdor-wormdingler-rev1-boe.dtb: panel@0: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
index 9832e752da35..262d6691abd9 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
@@ -124,14 +124,9 @@ panel: panel@0 {
backlight = <&backlight>;
rotation = <270>;

- ports {
- #address-cells = <1>;
- #size-cells = <0>;
- port@0 {
- reg = <0>;
- panel_in: endpoint {
- remote-endpoint = <&dsi0_out>;
- };
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&dsi0_out>;
};
};
};
--
2.34.1

2023-03-26 15:59:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 08/11] arm64: dts: qcom: sc7180-trogdor-lazor: correct panel compatible

innolux,n116bca-ea1 is not exactly compatible witg innolux,n116bge, as
they have their own driver data. Bindings do not allow fallback:

sc7180-trogdor-lazor-limozeen-nots-r4.dtb: panel: compatible: ['innolux,n116bca-ea1', 'innolux,n116bge'] is too long

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dts
index 235cda2bba5e..7f01573b5543 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dts
@@ -23,7 +23,7 @@ / {
/delete-node/&ap_ts;

&panel {
- compatible = "innolux,n116bca-ea1", "innolux,n116bge";
+ compatible = "innolux,n116bca-ea1";
};

&sdhc_2 {
--
2.34.1

2023-03-26 16:00:00

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 11/11] arm64: dts: qcom: sdm845-xiaomi-beryllium: correct compatible

Tianma FHD panel is supposed to be used with fallback compatible:

sdm845-xiaomi-beryllium-tianma.dtb: panel@0: compatible: ['tianma,fhd-video'] is too short

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
index 8e176111e599..e9427851ebaa 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
@@ -10,6 +10,6 @@ / {
};

&display_panel {
- compatible = "tianma,fhd-video";
+ compatible = "tianma,fhd-video", "novatek,nt36672a";
status = "okay";
};
--
2.34.1

2023-03-26 16:00:32

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 09/11] arm64: dts: qcom: sdm845-oneplus: drop invalid panel properties

Panel does not have children with unit-addresses thus address/size-cells
are not valid:

panel@0: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index b01542d79ae2..0c268c560d37 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -347,8 +347,6 @@ &dsi0 {
display_panel: panel@0 {
status = "disabled";

- #address-cells = <1>;
- #size-cells = <0>;
reg = <0>;

vddio-supply = <&vreg_l14a_1p88>;
--
2.34.1

2023-03-26 16:01:00

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 10/11] arm64: dts: qcom: sdm845-xiaomi-beryllium: drop invalid panel properties

Panel does not have children with unit-addresses thus address/size-cells
are not valid:

sdm845-xiaomi-beryllium-tianma.dtb: panel@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index e0fda4d754fe..e444ef1cd742 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -232,9 +232,6 @@ display_panel: panel@0 {
vddpos-supply = <&lab>;
vddneg-supply = <&ibb>;

- #address-cells = <1>;
- #size-cells = <0>;
-
backlight = <&pmi8998_wled>;
reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;

--
2.34.1

2023-03-26 22:22:50

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 02/11] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: use just "port" in panel

On Sun, 26 Mar 2023 at 18:58, Krzysztof Kozlowski
<[email protected]> wrote:
>
> The panel bindings expect to have only one port, thus they do not allow
> to use "ports" node:
>
> sc8280xp-lenovo-thinkpad-x13s.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-03-26 22:26:04

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 04/11] arm64: dts: qcom: sc7180-idp: use just "port" in panel

On Sun, 26 Mar 2023 at 18:58, Krzysztof Kozlowski
<[email protected]> wrote:
>
> The panel bindings expect to have only one port, thus they do not allow
> to use "ports" node:
>
> sc7180-idp.dtb: panel@0: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
> sc7180-idp.dtb: panel@0: 'port' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-03-26 22:27:34

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 01/11] arm64: dts: qcom: sdm845-cheza: use just "port" in Innolux panel

On Sun, 26 Mar 2023 at 18:58, Krzysztof Kozlowski
<[email protected]> wrote:
>
> The panel bindings expect to have only one port, thus they do not allow
> to use "ports" node:
>
> sdm845-cheza-r2.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-03-27 10:24:47

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 06/11] arm64: dts: qcom: sc7180-trogdor-wormdingler: use just "port" in panel

On 26/03/2023 18:57, Krzysztof Kozlowski wrote:
> The panel bindings expect to have only one port, thus they do not allow
> to use "ports" node:
>
> sc7180-trogdor-wormdingler-rev1-boe.dtb: panel@0: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-03-27 10:24:55

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 08/11] arm64: dts: qcom: sc7180-trogdor-lazor: correct panel compatible

On 26/03/2023 18:57, Krzysztof Kozlowski wrote:
> innolux,n116bca-ea1 is not exactly compatible witg innolux,n116bge, as
> they have their own driver data. Bindings do not allow fallback:
>
> sc7180-trogdor-lazor-limozeen-nots-r4.dtb: panel: compatible: ['innolux,n116bca-ea1', 'innolux,n116bge'] is too long
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-03-27 10:25:03

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 10/11] arm64: dts: qcom: sdm845-xiaomi-beryllium: drop invalid panel properties

On 26/03/2023 18:57, Krzysztof Kozlowski wrote:
> Panel does not have children with unit-addresses thus address/size-cells
> are not valid:
>
> sdm845-xiaomi-beryllium-tianma.dtb: panel@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 3 ---
> 1 file changed, 3 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-03-27 10:25:03

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 07/11] arm64: dts: qcom: sc7180-qcard: use just "port" in panel

On 26/03/2023 18:57, Krzysztof Kozlowski wrote:
> The panel bindings expect to have only one port, thus they do not allow
> to use "ports" node:
>
> sc7280-herobrine-zombie-nvme-lte.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-03-27 10:25:11

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 09/11] arm64: dts: qcom: sdm845-oneplus: drop invalid panel properties

On 26/03/2023 18:57, Krzysztof Kozlowski wrote:
> Panel does not have children with unit-addresses thus address/size-cells
> are not valid:
>
> panel@0: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 2 --
> 1 file changed, 2 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-03-27 10:27:16

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 11/11] arm64: dts: qcom: sdm845-xiaomi-beryllium: correct compatible

On 26/03/2023 18:57, Krzysztof Kozlowski wrote:
> Tianma FHD panel is supposed to be used with fallback compatible:
>
> sdm845-xiaomi-beryllium-tianma.dtb: panel@0: compatible: ['tianma,fhd-video'] is too short
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-03-28 14:58:28

by Caleb Connolly

[permalink] [raw]
Subject: Re: [PATCH 09/11] arm64: dts: qcom: sdm845-oneplus: drop invalid panel properties



On 26/03/2023 16:57, Krzysztof Kozlowski wrote:
> Panel does not have children with unit-addresses thus address/size-cells
> are not valid:
>
> panel@0: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Caleb Connolly <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> index b01542d79ae2..0c268c560d37 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -347,8 +347,6 @@ &dsi0 {
> display_panel: panel@0 {
> status = "disabled";
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0>;
>
> vddio-supply = <&vreg_l14a_1p88>;
> --
> 2.34.1
>

--
Kind Regards,
Caleb