2016-03-18 11:22:00

by Tomeu Vizoso

[permalink] [raw]
Subject: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node

So the dwmac device manages to probe again.

Signed-off-by: Tomeu Vizoso <[email protected]>
Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
---
arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
index 1ece66f3e162..4ba7ddecb478 100644
--- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
+++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
@@ -101,6 +101,14 @@
snps,reset-delays-us = <0 10000 30000>;
rx_delay = <0x10>;
tx_delay = <0x30>;
+ mdio0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "snps,dwmac-mdio";
+ ethphy1: ethernet-phy@1 {
+ reg = <1>;
+ };
+ };
};

&i2c0 {
--
2.5.0


2016-03-18 21:34:14

by Andreas Färber

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node

Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
> So the dwmac device manages to probe again.
>
> Signed-off-by: Tomeu Vizoso <[email protected]>
> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
> ---
> arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> index 1ece66f3e162..4ba7ddecb478 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> @@ -101,6 +101,14 @@
> snps,reset-delays-us = <0 10000 30000>;
> rx_delay = <0x10>;
> tx_delay = <0x30>;
> + mdio0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> + ethphy1: ethernet-phy@1 {
> + reg = <1>;
> + };
> + };

This is a) ugly for lack of white lines in between, b) unnecessary since
this is being fixed in the stmmac driver where it will benefit more than
just this one SoM.

Regards,
Andreas

> };
>
> &i2c0 {

--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)

2016-03-21 08:23:29

by Tomeu Vizoso

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node

On 18 March 2016 at 22:34, Andreas Färber <[email protected]> wrote:
> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>> So the dwmac device manages to probe again.
>>
>> Signed-off-by: Tomeu Vizoso <[email protected]>
>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>> ---
>> arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> index 1ece66f3e162..4ba7ddecb478 100644
>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>> @@ -101,6 +101,14 @@
>> snps,reset-delays-us = <0 10000 30000>;
>> rx_delay = <0x10>;
>> tx_delay = <0x30>;
>> + mdio0 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "snps,dwmac-mdio";
>> + ethphy1: ethernet-phy@1 {
>> + reg = <1>;
>> + };
>> + };
>
> This is a) ugly for lack of white lines in between, b) unnecessary since
> this is being fixed in the stmmac driver where it will benefit more than
> just this one SoM.

So is this redundant information, or just not necessary with the
present kernel driver because of some assumption in its current
implementation?

Thanks,

Tomeu

> Regards,
> Andreas
>
>> };
>>
>> &i2c0 {
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Subject: Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node

Hi

On Mon, Mar 21, 2016 at 9:23 AM, Tomeu Vizoso
<[email protected]> wrote:
> On 18 March 2016 at 22:34, Andreas Färber <[email protected]> wrote:
>> Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
>>> So the dwmac device manages to probe again.
>>>
>>> Signed-off-by: Tomeu Vizoso <[email protected]>
>>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>>> ---
>>> arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> index 1ece66f3e162..4ba7ddecb478 100644
>>> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
>>> @@ -101,6 +101,14 @@
>>> snps,reset-delays-us = <0 10000 30000>;
>>> rx_delay = <0x10>;
>>> tx_delay = <0x30>;
>>> + mdio0 {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + compatible = "snps,dwmac-mdio";
>>> + ethphy1: ethernet-phy@1 {
>>> + reg = <1>;
>>> + };
>>> + };
>>
>> This is a) ugly for lack of white lines in between, b) unnecessary since
>> this is being fixed in the stmmac driver where it will benefit more than
>> just this one SoM.
>
> So is this redundant information, or just not necessary with the
> present kernel driver because of some assumption in its current
> implementation?
>

I have the same fix on my firefly tree. Look likes correct and describe the
connection

Michael

> Thanks,
>
> Tomeu
>
>> Regards,
>> Andreas
>>
>>> };
>>>
>>> &i2c0 {
>>
>> --
>> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>> GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
>
> _______________________________________________
> Linux-rockchip mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-rockchip



--
| Michael Nazzareno Trimarchi Amarula Solutions BV |
| COO - Founder Cruquiuskade 47 |
| +31(0)851119172 Amsterdam 1018 AM NL |
| [`as] http://www.amarulasolutions.com |