2015-04-28 20:25:09

by Marek Belisko

[permalink] [raw]
Subject: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000

bq2700 slave driver depends on bq27x00-battery driver thus adding this
dependency to config. When bq2700 is build as module bq27x00-battery
will be loaded automatically.

Signed-off-by: Marek Belisko <[email protected]>
---
drivers/w1/slaves/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/w1/slaves/Kconfig b/drivers/w1/slaves/Kconfig
index cfe74d0..15c230a 100644
--- a/drivers/w1/slaves/Kconfig
+++ b/drivers/w1/slaves/Kconfig
@@ -128,6 +128,7 @@ config W1_SLAVE_DS28E04

config W1_SLAVE_BQ27000
tristate "BQ27000 slave support"
+ depends on BATTERY_BQ27X00_PLATFORM
help
Say Y here if you want to use a hdq
bq27000 slave support.
--
1.9.1


2015-04-30 13:38:27

by Evgeniy Polyakov

[permalink] [raw]
Subject: Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000

HI Marek

28.04.2015, 23:25, "Marek Belisko" <[email protected]>:
> bq2700 slave driver depends on bq27x00-battery driver thus adding this
> dependency to config. When bq2700 is build as module bq27x00-battery
> will be loaded automatically.
>
> Signed-off-by: Marek Belisko <[email protected]>

Patch looks good to me, but you should add appropriate maintainer to copy,
since I know nothing about bq27000 device.

2015-04-30 13:37:32

by Belisko Marek

[permalink] [raw]
Subject: Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000

+CC Sebastian

On Thu, Apr 30, 2015 at 3:30 PM, Evgeniy Polyakov <[email protected]> wrote:
> HI Marek
>
> 28.04.2015, 23:25, "Marek Belisko" <[email protected]>:
>> bq2700 slave driver depends on bq27x00-battery driver thus adding this
>> dependency to config. When bq2700 is build as module bq27x00-battery
>> will be loaded automatically.
>>
>> Signed-off-by: Marek Belisko <[email protected]>
>
> Patch looks good to me, but you should add appropriate maintainer to copy,
> since I know nothing about bq27000 device.

Sebastian could you please add your Ack to this change or comment if
you disagree? Thanks.

BR,

marek

--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

2015-05-15 19:57:42

by Belisko Marek

[permalink] [raw]
Subject: Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000

Sebastian ping. Thanks.

On Thu, Apr 30, 2015 at 3:37 PM, Belisko Marek <[email protected]> wrote:
> +CC Sebastian
>
> On Thu, Apr 30, 2015 at 3:30 PM, Evgeniy Polyakov <[email protected]> wrote:
>> HI Marek
>>
>> 28.04.2015, 23:25, "Marek Belisko" <[email protected]>:
>>> bq2700 slave driver depends on bq27x00-battery driver thus adding this
>>> dependency to config. When bq2700 is build as module bq27x00-battery
>>> will be loaded automatically.
>>>
>>> Signed-off-by: Marek Belisko <[email protected]>
>>
>> Patch looks good to me, but you should add appropriate maintainer to copy,
>> since I know nothing about bq27000 device.
>
> Sebastian could you please add your Ack to this change or comment if
> you disagree? Thanks.
>
> BR,
>
> marek
>
> --
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
>
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> twitter: #opennandra
> web: http://open-nandra.com

BR,

marek

--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

2015-05-15 21:00:44

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000

Hi,

On Fri, May 15, 2015 at 09:57:38PM +0200, Belisko Marek wrote:
>
> On Thu, Apr 30, 2015 at 3:37 PM, Belisko Marek <[email protected]> wrote:
> > +CC Sebastian
> >
> > On Thu, Apr 30, 2015 at 3:30 PM, Evgeniy Polyakov <[email protected]> wrote:
> >> HI Marek
> >>
> >> 28.04.2015, 23:25, "Marek Belisko" <[email protected]>:
> >>> bq2700 slave driver depends on bq27x00-battery driver thus adding this
> >>> dependency to config. When bq2700 is build as module bq27x00-battery
> >>> will be loaded automatically.
> >>>
> >>> Signed-off-by: Marek Belisko <[email protected]>
> >>
> >> Patch looks good to me, but you should add appropriate maintainer to copy,
> >> since I know nothing about bq27000 device.
> >
> > Sebastian could you please add your Ack to this change or comment if
> > you disagree? Thanks.
>
> Sebastian ping. Thanks.

Sorry, did not noticed this thread so far:

Acked-By: Sebastian Reichel <[email protected]>

-- Sebastian


Attachments:
(No filename) (955.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments