2022-08-23 09:02:21

by CGEL

Subject: [PATCH linux-next] mm/slab_common: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value from __kmem_cache_shrink() directly instead of storing it
in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
mm/slab_common.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/mm/slab_common.c b/mm/slab_common.c
index 17996649cfe3..0dfa3cfb6be5 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -495,13 +495,9 @@ EXPORT_SYMBOL(kmem_cache_destroy);
*/
int kmem_cache_shrink(struct kmem_cache *cachep)
{
- int ret;
-
-
kasan_cache_shrink(cachep);
- ret = __kmem_cache_shrink(cachep);

- return ret;
+ return __kmem_cache_shrink(cachep);
}
EXPORT_SYMBOL(kmem_cache_shrink);

--
2.25.1

2022-08-23 11:17:31

by Hyeonggon Yoo

Subject: Re: [PATCH linux-next] mm/slab_common: Remove the unneeded result variable

On Tue, Aug 23, 2022 at 4:52 PM <[email protected]> wrote:
>
> From: ye xingchen <[email protected]>
>
> Return the value from __kmem_cache_shrink() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> mm/slab_common.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 17996649cfe3..0dfa3cfb6be5 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -495,13 +495,9 @@ EXPORT_SYMBOL(kmem_cache_destroy);
> */
> int kmem_cache_shrink(struct kmem_cache *cachep)
> {
> - int ret;
> -
> -
> kasan_cache_shrink(cachep);
> - ret = __kmem_cache_shrink(cachep);
>
> - return ret;
> + return __kmem_cache_shrink(cachep);
> }
> EXPORT_SYMBOL(kmem_cache_shrink);
>

Acked-by: Hyeonggon Yoo <[email protected]>

> --
> 2.25.1

2022-08-23 17:22:56

by Vlastimil Babka

Subject: Re: [PATCH linux-next] mm/slab_common: Remove the unneeded result variable

On 8/23/22 09:52, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Return the value from __kmem_cache_shrink() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>

Thanks, added to slab.git for-6.1/trivial

> ---
> mm/slab_common.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 17996649cfe3..0dfa3cfb6be5 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -495,13 +495,9 @@ EXPORT_SYMBOL(kmem_cache_destroy);
> */
> int kmem_cache_shrink(struct kmem_cache *cachep)
> {
> - int ret;
> -
> -
> kasan_cache_shrink(cachep);
> - ret = __kmem_cache_shrink(cachep);
>
> - return ret;
> + return __kmem_cache_shrink(cachep);
> }
> EXPORT_SYMBOL(kmem_cache_shrink);
>