2017-11-29 18:16:04

by Stephane Eranian

[permalink] [raw]
Subject: Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo
<[email protected]> wrote:
>
> Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu:
> > From: Ben Gainey <[email protected]>
> > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
> > return -1;
> > }
> >
> > - flen = strlen(file) + 1;
> > + for (i = 0; i < nr_lines; ++i) {
> > + flen += strlen(file_names[i]) + 1;
> > + }
>
>
> Please follow the coding standard used in this file and in tools/perf,
> which is the kernel one.
>
> Thanks for providing instructions on how to reproduce the problem!
>
> Stephane, can you please Ack this?
>
Trying to test this but do not see the source code from example, yet.

>
> - Arnaldo

From 1585278490703007384@xxx Tue Nov 28 03:23:00 +0000 2017
X-GM-THRID: 1584814413904944193
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread