2021-05-11 06:42:52

by Jian-Hong Pan

Subject: [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a
different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

Signed-off-by: Chris Chiu <[email protected]>
Signed-off-by: Jian-Hong Pan <[email protected]>
---
drivers/acpi/ec.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 13565629ce0a..e8c5da2b964a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
{
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+ {
ec_honor_ecdt_gpe, "ASUS X550VXK", {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--
2.31.1

2021-05-18 02:03:03

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops

On Tue, May 11, 2021 at 8:40 AM Jian-Hong Pan <[email protected]> wrote:
>
> From: Chris Chiu <[email protected]>
>
> More ASUS laptops have the _GPE define in the DSDT table with a
> different value than the _GPE number in the ECDT.
>
> This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
>
> Add model info to the quirks list.
>
> Signed-off-by: Chris Chiu <[email protected]>
> Signed-off-by: Jian-Hong Pan <[email protected]>
> ---
> drivers/acpi/ec.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 13565629ce0a..e8c5da2b964a 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> + {
> ec_honor_ecdt_gpe, "ASUS X550VXK", {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> --

Applied as 5.14 material under a different subject ("ACPI: EC: Make
more Asus laptops use ECDT _GPE"), thanks!

2021-05-18 06:15:37

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops

On Mon, May 17, 2021 at 4:32 PM Rafael J. Wysocki <[email protected]> wrote:
>
> On Tue, May 11, 2021 at 8:40 AM Jian-Hong Pan <[email protected]> wrote:
> >
> > From: Chris Chiu <[email protected]>
> >
> > More ASUS laptops have the _GPE define in the DSDT table with a
> > different value than the _GPE number in the ECDT.
> >
> > This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
> >
> > Add model info to the quirks list.
> >
> > Signed-off-by: Chris Chiu <[email protected]>
> > Signed-off-by: Jian-Hong Pan <[email protected]>
> > ---
> > drivers/acpi/ec.c | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> > index 13565629ce0a..e8c5da2b964a 100644
> > --- a/drivers/acpi/ec.c
> > +++ b/drivers/acpi/ec.c
> > @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> > {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> > + {
> > ec_honor_ecdt_gpe, "ASUS X550VXK", {
> > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> > --
>
> Applied as 5.14 material under a different subject ("ACPI: EC: Make
> more Asus laptops use ECDT _GPE"), thanks!

And dropped, because the [email protected] email address is bouncing.

Please resend with a valid email address in the From: field, thanks!

2021-05-19 19:05:49

by Jian-Hong Pan

Subject: [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a
different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

Signed-off-by: Chris Chiu <[email protected]>
Signed-off-by: Jian-Hong Pan <[email protected]>
---
v2: Edit the author information with valid email address

drivers/acpi/ec.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 13565629ce0a..e8c5da2b964a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
{
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+ {
ec_honor_ecdt_gpe, "ASUS X550VXK", {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--
2.31.1

2021-05-19 19:27:23

by Chris Chiu

Subject: Re: [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE

On Wed, May 19, 2021 at 5:53 PM Rafael J. Wysocki <[email protected]> wrote:
>
> On Wed, May 19, 2021 at 5:11 AM Jian-Hong Pan <[email protected]> wrote:
> >
> > From: Chris Chiu <[email protected]>
> >
> > More ASUS laptops have the _GPE define in the DSDT table with a
> > different value than the _GPE number in the ECDT.
> >
> > This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
> >
> > Add model info to the quirks list.
> >
> > Signed-off-by: Chris Chiu <[email protected]>
>
> This has to match the From address.
>
> Chris, can the e-mail address in the S-o-b be changed?
>

Sure. I've updated the .mailmap. Jian-Hong, could you help fix the
S-o-b? Thanks.

Chris

> > Signed-off-by: Jian-Hong Pan <[email protected]>
> > ---
> > v2: Edit the author information with valid email address
> >
> > drivers/acpi/ec.c | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> > index 13565629ce0a..e8c5da2b964a 100644
> > --- a/drivers/acpi/ec.c
> > +++ b/drivers/acpi/ec.c
> > @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> > {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> > + {
> > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> > + {
> > ec_honor_ecdt_gpe, "ASUS X550VXK", {
> > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> > --
> > 2.31.1
> >

2021-05-19 19:27:37

by Rafael J. Wysocki

Subject: Re: [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE

On Wed, May 19, 2021 at 5:11 AM Jian-Hong Pan <[email protected]> wrote:
>
> From: Chris Chiu <[email protected]>
>
> More ASUS laptops have the _GPE define in the DSDT table with a
> different value than the _GPE number in the ECDT.
>
> This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
>
> Add model info to the quirks list.
>
> Signed-off-by: Chris Chiu <[email protected]>

This has to match the From address.

Chris, can the e-mail address in the S-o-b be changed?

> Signed-off-by: Jian-Hong Pan <[email protected]>
> ---
> v2: Edit the author information with valid email address
>
> drivers/acpi/ec.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 13565629ce0a..e8c5da2b964a 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> + {
> ec_honor_ecdt_gpe, "ASUS X550VXK", {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> --
> 2.31.1
>

2021-05-20 03:14:57

by Jian-Hong Pan

Subject: [PATCH v3] ACPI: EC: Make more Asus laptops use ECDT _GPE

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a
different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

Signed-off-by: Chris Chiu <[email protected]>
Signed-off-by: Jian-Hong Pan <[email protected]>
---
v2: Edit the author information with valid email address

v3: Edit Chris' S-o-b with current valid email address

drivers/acpi/ec.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 13565629ce0a..e8c5da2b964a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
{
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+ {
+ ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+ {
ec_honor_ecdt_gpe, "ASUS X550VXK", {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--
2.31.1

2021-05-21 20:23:58

by Rafael J. Wysocki

Subject: Re: [PATCH v3] ACPI: EC: Make more Asus laptops use ECDT _GPE

On Thu, May 20, 2021 at 5:13 AM Jian-Hong Pan <[email protected]> wrote:
>
> From: Chris Chiu <[email protected]>
>
> More ASUS laptops have the _GPE define in the DSDT table with a
> different value than the _GPE number in the ECDT.
>
> This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
>
> Add model info to the quirks list.
>
> Signed-off-by: Chris Chiu <[email protected]>
> Signed-off-by: Jian-Hong Pan <[email protected]>
> ---
> v2: Edit the author information with valid email address
>
> v3: Edit Chris' S-o-b with current valid email address
>
> drivers/acpi/ec.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 13565629ce0a..e8c5da2b964a 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> + {
> + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> + {
> ec_honor_ecdt_gpe, "ASUS X550VXK", {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> --

Applied as 5.14 material, thanks!