[email protected] [email protected]
On Sun, Nov 29, 2015 at 9:08 PM, Anand Moon <[email protected]> wrote:
> Hi Anup,
>
> On 27 November 2015 at 17:26, Anup Limbu <[email protected]> wrote:
>> Replacing return type of function as void from int and removing
>> unused variable ret.
>>
>> Signed-off-by: Anup Limbu <[email protected]>
>> ---
>> tools/thermal/tmon/pid.c | 5 +----
>> tools/thermal/tmon/tmon.h | 2 +-
>> 2 files changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/tools/thermal/tmon/pid.c b/tools/thermal/tmon/pid.c
>> index fd7e9e9..c034bf3 100644
>> --- a/tools/thermal/tmon/pid.c
>> +++ b/tools/thermal/tmon/pid.c
>> @@ -63,10 +63,8 @@ static double xk_1, xk_2; /* input temperature x[k-#] */
>> *
>> * add a flag for tuning PID
>> */
>> -int init_thermal_controller(void)
>> +void init_thermal_controller(void)
>> {
>> - int ret = 0;
>> -
>> /* init pid params */
>> p_param.ts = ticktime;
>> /* TODO: get it from TUI tuning tab */
>> @@ -76,7 +74,6 @@ int init_thermal_controller(void)
>>
>> p_param.t_target = target_temp_user;
>>
>> - return ret;
>> }
>>
>> void controller_reset(void)
>> diff --git a/tools/thermal/tmon/tmon.h b/tools/thermal/tmon/tmon.h
>> index 9e3c49c..016569d 100644
>> --- a/tools/thermal/tmon/tmon.h
>> +++ b/tools/thermal/tmon/tmon.h
>> @@ -139,7 +139,7 @@ struct pid_params {
>> double y_k;
>> };
>>
>> -extern int init_thermal_controller(void);
>> +extern void init_thermal_controller(void);
>> extern void controller_handler(const double xk, double *yk);
>>
>> extern struct tmon_platform_data ptdata;
>> --
>> 1.9.1
>>
>
> BTW, next time when sending a thermal related change, please cc
> [email protected], or else the change may got because we usually
> rely on https://patchwork.kernel.org/project/linux-pm/list/ to review
> and scrub the patches. :)
>
> ---Zhang Rui <[email protected]>
>
> Tested-by: Anand Moon <[email protected]>
>
> -Anand Moon