2021-11-04 19:57:01

by Eugenio Perez Martin

Subject: [PATCH] vdpa: Mark vdpa_config_ops.get_vq_notification as optional

Since vhost_vdpa_mmap checks for its existence before calling it.

Signed-off-by: Eugenio Pérez <[email protected]>
---
include/linux/vdpa.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
index c3011ccda430..0bdc7f785394 100644
--- a/include/linux/vdpa.h
+++ b/include/linux/vdpa.h
@@ -155,7 +155,7 @@ struct vdpa_map_file {
* @vdev: vdpa device
* @idx: virtqueue index
* @state: pointer to returned state (last_avail_idx)
- * @get_vq_notification: Get the notification area for a virtqueue
+ * @get_vq_notification: Get the notification area for a virtqueue (optional)
* @vdev: vdpa device
* @idx: virtqueue index
* Returns the notifcation area
--
2.27.0

2021-11-05 04:12:38

by Jason Wang

Subject: Re: [PATCH] vdpa: Mark vdpa_config_ops.get_vq_notification as optional

On Fri, Nov 5, 2021 at 3:53 AM Eugenio Pérez <[email protected]> wrote:
>
> Since vhost_vdpa_mmap checks for its existence before calling it.
>
> Signed-off-by: Eugenio Pérez <[email protected]>

Acked-by: Jason Wang <[email protected]>

> ---
> include/linux/vdpa.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
> index c3011ccda430..0bdc7f785394 100644
> --- a/include/linux/vdpa.h
> +++ b/include/linux/vdpa.h
> @@ -155,7 +155,7 @@ struct vdpa_map_file {
> * @vdev: vdpa device
> * @idx: virtqueue index
> * @state: pointer to returned state (last_avail_idx)
> - * @get_vq_notification: Get the notification area for a virtqueue
> + * @get_vq_notification: Get the notification area for a virtqueue (optional)
> * @vdev: vdpa device
> * @idx: virtqueue index
> * Returns the notifcation area
> --
> 2.27.0
>

2021-11-05 11:25:21

by Stefano Garzarella

Subject: Re: [PATCH] vdpa: Mark vdpa_config_ops.get_vq_notification as optional

On Thu, Nov 04, 2021 at 08:52:48PM +0100, Eugenio P?rez wrote:
>Since vhost_vdpa_mmap checks for its existence before calling it.
>
>Signed-off-by: Eugenio P?rez <[email protected]>
>---
> include/linux/vdpa.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
>index c3011ccda430..0bdc7f785394 100644
>--- a/include/linux/vdpa.h
>+++ b/include/linux/vdpa.h
>@@ -155,7 +155,7 @@ struct vdpa_map_file {
> * @vdev: vdpa device
> * @idx: virtqueue index
> * @state: pointer to returned state (last_avail_idx)
>- * @get_vq_notification: Get the notification area for a virtqueue
>+ * @get_vq_notification: Get the notification area for a virtqueue (optional)
> * @vdev: vdpa device
> * @idx: virtqueue index
> * Returns the notifcation area
>--
>2.27.0
>

Reviewed-by: Stefano Garzarella <[email protected]>