2021-01-15 15:36:32

by Tom Rix

[permalink] [raw]
Subject: [PATCH] tracing: remove definition of DEBUG

From: Tom Rix <[email protected]>

Defining DEBUG should only be done in development.
So remove DEBUG.

Signed-off-by: Tom Rix <[email protected]>
---
kernel/trace/trace_mmiotrace.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c
index 84582bf1ed5f..2c3c31791497 100644
--- a/kernel/trace/trace_mmiotrace.c
+++ b/kernel/trace/trace_mmiotrace.c
@@ -5,8 +5,6 @@
* Copyright (C) 2008 Pekka Paalanen <[email protected]>
*/

-#define DEBUG 1
-
#include <linux/kernel.h>
#include <linux/mmiotrace.h>
#include <linux/pci.h>
--
2.27.0


2021-01-18 20:43:14

by Karol Herbst

[permalink] [raw]
Subject: Re: [Nouveau] [PATCH] tracing: remove definition of DEBUG

Reviewed-by: Karol Herbst <[email protected]>

On Fri, Jan 15, 2021 at 11:51 PM <[email protected]> wrote:
>
> From: Tom Rix <[email protected]>
>
> Defining DEBUG should only be done in development.
> So remove DEBUG.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> kernel/trace/trace_mmiotrace.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c
> index 84582bf1ed5f..2c3c31791497 100644
> --- a/kernel/trace/trace_mmiotrace.c
> +++ b/kernel/trace/trace_mmiotrace.c
> @@ -5,8 +5,6 @@
> * Copyright (C) 2008 Pekka Paalanen <[email protected]>
> */
>
> -#define DEBUG 1
> -
> #include <linux/kernel.h>
> #include <linux/mmiotrace.h>
> #include <linux/pci.h>
> --
> 2.27.0
>
> _______________________________________________
> Nouveau mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/nouveau
>