Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
Signed-off-by: Ryan Chen <[email protected]>
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
index 89be13197780..2772796e215e 100644
--- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
+++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
@@ -237,3 +237,11 @@
&fsim0 {
status = "okay";
};
+
+&ehci1 {
+ status = "okay";
+};
+
+&uhci {
+ status = "okay";
+};
--
2.17.1
On Wed, Sep 30, 2020 at 12:08:23PM +0800, Ryan Chen wrote:
> Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
>
> Signed-off-by: Ryan Chen <[email protected]>
Reviewed-by: Tao Ren <[email protected]>
On Wed, 30 Sep 2020 at 04:08, Ryan Chen <[email protected]> wrote:
>
> Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
>
> Signed-off-by: Ryan Chen <[email protected]>
Reviewed-by: Joel Stanley <[email protected]>
> ---
> arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> index 89be13197780..2772796e215e 100644
> --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> @@ -237,3 +237,11 @@
> &fsim0 {
> status = "okay";
> };
> +
> +&ehci1 {
> + status = "okay";
> +};
> +
> +&uhci {
> + status = "okay";
> +};
> --
> 2.17.1
>
v2:
-[1/3]: Add SCSI,BLK_DEV_SD,USB_STORAGE in defconfig.
-[2/3]: Fix continuation lines.
v1:
-The patches enable UHCI driver in AST2600 and also
enable USB host in aspeed-ast2600-evb.dts.
Ryan Chen (3):
configs: aspeed: enable UHCI driver in defconfig
usb: host: add uhci compatible support for ast2600-uhci
ARM: dts: add ehci uhci enable in evb dts
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
arch/arm/configs/aspeed_g5_defconfig | 4 ++++
drivers/usb/host/uhci-platform.c | 3 ++-
3 files changed, 14 insertions(+), 1 deletion(-)
--
2.17.1
Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
Signed-off-by: Ryan Chen <[email protected]>
---
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
index 89be13197780..2772796e215e 100644
--- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
+++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
@@ -237,3 +237,11 @@
&fsim0 {
status = "okay";
};
+
+&ehci1 {
+ status = "okay";
+};
+
+&uhci {
+ status = "okay";
+};
--
2.17.1
v2:
-Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
-Enable UHCI driver in aspeed_g5_defconfig.
Signed-off-by: Ryan Chen <[email protected]>
---
arch/arm/configs/aspeed_g5_defconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/configs/aspeed_g5_defconfig b/arch/arm/configs/aspeed_g5_defconfig
index 2bacd8c90f4b..7a6b0b79be9f 100644
--- a/arch/arm/configs/aspeed_g5_defconfig
+++ b/arch/arm/configs/aspeed_g5_defconfig
@@ -90,6 +90,8 @@ CONFIG_BLK_DEV_NBD=y
CONFIG_MCTP_LPC=y
CONFIG_EEPROM_AT24=y
CONFIG_EEPROM_AT25=y
+CONFIG_SCSI=y
+CONFIG_BLK_DEV_SD=y
CONFIG_MD=y
CONFIG_BLK_DEV_DM=y
CONFIG_DM_VERITY=y
@@ -212,6 +214,8 @@ CONFIG_USB_DYNAMIC_MINORS=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_ROOT_HUB_TT=y
CONFIG_USB_EHCI_HCD_PLATFORM=y
+CONFIG_USB_UHCI_HCD=y
+CONFIG_USB_STORAGE=y
CONFIG_USB_GADGET=y
CONFIG_USB_ASPEED_VHUB=y
CONFIG_USB_CONFIGFS=y
--
2.17.1
On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> v2:
> -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> v1:
> -Enable UHCI driver in aspeed_g5_defconfig.
>
> Signed-off-by: Ryan Chen <[email protected]>
Why do you need this in a defconfig?
On Fri, 9 Oct 2020 at 04:45, Greg KH <[email protected]> wrote:
>
> On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> > v2:
> > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> > v1:
> > -Enable UHCI driver in aspeed_g5_defconfig.
> >
> > Signed-off-by: Ryan Chen <[email protected]>
>
> Why do you need this in a defconfig?
I would prefer configurations that are being used to be present in the
defconfig so we can test it. I think this is a sensible change.
Ryan, I gave you my Reviewed-by for the last version of the patch. As
you did not change the contents of this patch it is fine for you to
leave my Reviewed-by on it.
Cheers,
Joel
On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote:
> On Fri, 9 Oct 2020 at 04:45, Greg KH <[email protected]> wrote:
> >
> > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> > > v2:
> > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> > > v1:
> > > -Enable UHCI driver in aspeed_g5_defconfig.
> > >
> > > Signed-off-by: Ryan Chen <[email protected]>
> >
> > Why do you need this in a defconfig?
>
> I would prefer configurations that are being used to be present in the
> defconfig so we can test it. I think this is a sensible change.
Then it needs to be described in the changelog, otherwise we have no
idea why this is happening :)
thanks,
greg k-h
> -----Original Message-----
> From: Joel Stanley <[email protected]>
> Sent: Friday, October 9, 2020 12:55 PM
> To: Greg KH <[email protected]>
> Cc: Ryan Chen <[email protected]>; Andrew Jeffery
> <[email protected]>; Linux ARM <[email protected]>;
> linux-aspeed <[email protected]>; Linux Kernel Mailing List
> <[email protected]>; [email protected]; BMC-SW
> <[email protected]>; Alan Stern <[email protected]>
> Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
>
> On Fri, 9 Oct 2020 at 04:45, Greg KH <[email protected]> wrote:
> >
> > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> > > v2:
> > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> > > v1:
> > > -Enable UHCI driver in aspeed_g5_defconfig.
> > >
> > > Signed-off-by: Ryan Chen <[email protected]>
> >
> > Why do you need this in a defconfig?
>
> I would prefer configurations that are being used to be present in the defconfig
> so we can test it. I think this is a sensible change.
>
> Ryan, I gave you my Reviewed-by for the last version of the patch. As you did
> not change the contents of this patch it is fine for you to leave my Reviewed-by
> on it.
Joel, thanks the review, so I need add Reviewed-by at each patch if someone have reviewed the previous patch,
am I right?
> -----Original Message-----
> From: Greg KH <[email protected]>
> Sent: Friday, October 9, 2020 1:47 PM
> To: Joel Stanley <[email protected]>
> Cc: Ryan Chen <[email protected]>; Andrew Jeffery
> <[email protected]>; Linux ARM <[email protected]>;
> linux-aspeed <[email protected]>; Linux Kernel Mailing List
> <[email protected]>; [email protected]; BMC-SW
> <[email protected]>; Alan Stern <[email protected]>
> Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
>
> On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote:
> > On Fri, 9 Oct 2020 at 04:45, Greg KH <[email protected]> wrote:
> > >
> > > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> > > > v2:
> > > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> > > > v1:
> > > > -Enable UHCI driver in aspeed_g5_defconfig.
> > > >
> > > > Signed-off-by: Ryan Chen <[email protected]>
> > >
> > > Why do you need this in a defconfig?
> >
> > I would prefer configurations that are being used to be present in the
> > defconfig so we can test it. I think this is a sensible change.
>
> Then it needs to be described in the changelog, otherwise we have no idea
> why this is happening :)
>
Ok, will send new version describe it.
HEllo!
On 09.10.2020 5:49, Ryan Chen wrote:
> Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?
> Signed-off-by: Ryan Chen <[email protected]>
[...]
MBR, Sergei
Hello Segei,
> -----Original Message-----
> From: Sergei Shtylyov <[email protected]>
> Sent: Friday, October 9, 2020 4:23 PM
> To: Ryan Chen <[email protected]>; Joel Stanley <[email protected]>;
> Andrew Jeffery <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; BMC-SW <[email protected]>; Alan Stern
> <[email protected]>
> Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
>
> HEllo!
>
> On 09.10.2020 5:49, Ryan Chen wrote:
>
> > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
>
> Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?
>
Yes, it is enable for AST2600 EVB.
> > Signed-off-by: Ryan Chen <[email protected]>
> [...]
>
> MBR, Sergei
> -----Original Message-----
> From: Andrew Jeffery <[email protected]>
> Sent: Thursday, October 22, 2020 7:45 AM
> To: Ryan Chen <[email protected]>; Sergei Shtylyov
> <[email protected]>; Joel Stanley <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]; BMC-SW
> <[email protected]>; Alan Stern <[email protected]>
> Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
>
> Hi Ryan,
>
> On Mon, 12 Oct 2020, at 11:13, Ryan Chen wrote:
> > Hello Segei,
> >
> > > -----Original Message-----
> > > From: Sergei Shtylyov <[email protected]>
> > > Sent: Friday, October 9, 2020 4:23 PM
> > > To: Ryan Chen <[email protected]>; Joel Stanley
> > > <[email protected]>; Andrew Jeffery <[email protected]>;
> > > [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; BMC-SW <[email protected]>; Alan
> > > Stern <[email protected]>
> > > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb
> > > dts
> > >
> > > HEllo!
> > >
> > > On 09.10.2020 5:49, Ryan Chen wrote:
> > >
> > > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
> > >
> > > Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?
> > >
> >
> > Yes, it is enable for AST2600 EVB.
>
> I think Sergei was suggesting you change the wording of the commit message.
>
Thanks, will resend the patch with modification.
Hi Ryan,
On Mon, 12 Oct 2020, at 11:13, Ryan Chen wrote:
> Hello Segei,
>
> > -----Original Message-----
> > From: Sergei Shtylyov <[email protected]>
> > Sent: Friday, October 9, 2020 4:23 PM
> > To: Ryan Chen <[email protected]>; Joel Stanley <[email protected]>;
> > Andrew Jeffery <[email protected]>; [email protected];
> > [email protected]; [email protected];
> > [email protected]; BMC-SW <[email protected]>; Alan Stern
> > <[email protected]>
> > Subject: Re: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts
> >
> > HEllo!
> >
> > On 09.10.2020 5:49, Ryan Chen wrote:
> >
> > > Add EHCI UHCI enable build in aspeed-ast2600-evb.dts
> >
> > Enable ECHI/UHCI for the Aspeed AST2600 EVB, perhaps?
> >
>
> Yes, it is enable for AST2600 EVB.
I think Sergei was suggesting you change the wording of the commit message.
Andrew