2020-04-07 15:43:54

by Bartosz Golaszewski

[permalink] [raw]
Subject: [PATCH] gpio: pca953x: disable regmap locking

From: Bartosz Golaszewski <[email protected]>

This driver uses its own locking but regmap silently uses a mutex for
all operations too. Add the option to disable locking to the regmap
config struct.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/gpio/gpio-pca953x.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 5638b4e5355f..40da1954d74b 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -306,6 +306,7 @@ static const struct regmap_config pca953x_i2c_regmap = {
.writeable_reg = pca953x_writeable_register,
.volatile_reg = pca953x_volatile_register,

+ .disable_locking = true,
.cache_type = REGCACHE_RBTREE,
/* REVISIT: should be 0x7f but some 24 bit chips use REG_ADDR_AI */
.max_register = 0xff,
--
2.25.0


2020-04-07 16:46:29

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] gpio: pca953x: disable regmap locking

On Tue, Apr 7, 2020 at 5:42 PM Bartosz Golaszewski <[email protected]> wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> This driver uses its own locking but regmap silently uses a mutex for
> all operations too. Add the option to disable locking to the regmap
> config struct.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

SATA on Salvator-XS with R-Car H3 ES2.0 relies on a pca9654 GPIO hog
and still works, so
Tested-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-04-16 09:56:16

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] gpio: pca953x: disable regmap locking

On Tue, Apr 7, 2020 at 5:42 PM Bartosz Golaszewski <[email protected]> wrote:

> From: Bartosz Golaszewski <[email protected]>
>
> This driver uses its own locking but regmap silently uses a mutex for
> all operations too. Add the option to disable locking to the regmap
> config struct.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Please queued this in your next devel pull request for me, thanks!

Yours,
Linus Walleij