2018-02-10 21:06:54

by SF Markus Elfring

Subject: [PATCH 0/2] GPIO-OMAP: Adjustments for omap_gpio_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 10 Feb 2018 21:56:54 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/gpio/gpio-omap.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.16.1

2018-02-10 21:08:20

by SF Markus Elfring

Subject: [PATCH 1/2] gpio: omap: Delete an error message for a failed memory allocation in omap_gpio_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 10 Feb 2018 21:46:30 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/gpio/gpio-omap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index ab5035b96886..4db6f13fa133 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1158,10 +1158,8 @@ static int omap_gpio_probe(struct platform_device *pdev)
return -EINVAL;

bank = devm_kzalloc(dev, sizeof(struct gpio_bank), GFP_KERNEL);
- if (!bank) {
- dev_err(dev, "Memory alloc failed\n");
+ if (!bank)
return -ENOMEM;
- }

irqc = devm_kzalloc(dev, sizeof(*irqc), GFP_KERNEL);
if (!irqc)
--
2.16.1

2018-02-10 21:10:03

by SF Markus Elfring

Subject: [PATCH 2/2] gpio: omap: Improve a size determination in omap_gpio_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 10 Feb 2018 21:49:22 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/gpio/gpio-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 4db6f13fa133..35971a341c40 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1157,7 +1157,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
if (!pdata)
return -EINVAL;

- bank = devm_kzalloc(dev, sizeof(struct gpio_bank), GFP_KERNEL);
+ bank = devm_kzalloc(dev, sizeof(*bank), GFP_KERNEL);
if (!bank)
return -ENOMEM;

--
2.16.1

2018-02-12 17:34:18

by Grygorii Strashko

Subject: Re: [PATCH 0/2] GPIO-OMAP: Adjustments for omap_gpio_probe()

On 02/10/2018 03:05 PM, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sat, 10 Feb 2018 21:56:54 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Delete an error message for a failed memory allocation
> Improve a size determination
>
> drivers/gpio/gpio-omap.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>

For series:
Acked-by: Grygorii Strashko <[email protected]>

--
regards,
-grygorii

2018-02-22 14:18:05

by Linus Walleij

Subject: Re: [PATCH 1/2] gpio: omap: Delete an error message for a failed memory allocation in omap_gpio_probe()

On Sat, Feb 10, 2018 at 10:07 PM, SF Markus Elfring
<[email protected]> wrote:

> From: Markus Elfring <[email protected]>
> Date: Sat, 10 Feb 2018 21:46:30 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Patch applied.

Yours,
Linus Walleij

2018-02-22 14:18:29

by Linus Walleij

Subject: Re: [PATCH 2/2] gpio: omap: Improve a size determination in omap_gpio_probe()

On Sat, Feb 10, 2018 at 10:08 PM, SF Markus Elfring
<[email protected]> wrote:

> From: Markus Elfring <[email protected]>
> Date: Sat, 10 Feb 2018 21:49:22 +0100
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Patch applied.

Yours,
Linus Walleij