2024-05-08 17:06:30

by Andy Shevchenko

Subject: [PATCH v1 1/1] usb: fotg210: Use *-y instead of *-objs in Makefile

*-objs suffix is reserved rather for (user-space) host programs while
usually *-y suffix is used for kernel drivers (although *-objs works
for that purpose for now).

Let's correct the old usages of *-objs in Makefiles.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/usb/fotg210/Makefile | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/fotg210/Makefile b/drivers/usb/fotg210/Makefile
index 5aecff21f24b..8f5b0fb9b988 100644
--- a/drivers/usb/fotg210/Makefile
+++ b/drivers/usb/fotg210/Makefile
@@ -1,10 +1,6 @@
# SPDX-License-Identifier: GPL-2.0

-# This setup links the different object files into one single
-# module so we don't have to EXPORT() a lot of internal symbols
-# or create unnecessary submodules.
-fotg210-objs-y += fotg210-core.o
-fotg210-objs-$(CONFIG_USB_FOTG210_HCD) += fotg210-hcd.o
-fotg210-objs-$(CONFIG_USB_FOTG210_UDC) += fotg210-udc.o
-fotg210-objs := $(fotg210-objs-y)
obj-$(CONFIG_USB_FOTG210) += fotg210.o
+fotg210-y := fotg210-core.o
+fotg210-$(CONFIG_USB_FOTG210_HCD) += fotg210-hcd.o
+fotg210-$(CONFIG_USB_FOTG210_UDC) += fotg210-udc.o
--
2.43.0.rc1.1336.g36b5255a03ac

2024-05-08 18:12:06

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] usb: fotg210: Use *-y instead of *-objs in Makefile

On Wed, May 08, 2024 at 06:04:06PM +0300, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
>
> Let's correct the old usages of *-objs in Makefiles.

Note, the original approach is weirdest from existing. Only a few
drivers use this (-objs-y) one most likely by mistake.

--
With Best Regards,
Andy Shevchenko

2024-05-27 13:19:05

by Linus Walleij

Subject: Re: [PATCH v1 1/1] usb: fotg210: Use *-y instead of *-objs in Makefile

On Wed, May 8, 2024 at 5:04 PM Andy Shevchenko
<[email protected]> wrote:

> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
>
> Let's correct the old usages of *-objs in Makefiles.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

I haven't examined the claim in detail but I trust you so:
Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij