On Sat, 31 Oct 2015 22:02:53 +0100
Linus Walleij <[email protected]> wrote:
> On Fri, Oct 30, 2015 at 11:36 AM, Alban Bedel <[email protected]> wrote:
>
> > Turn the ath79 driver into a true driver supporting multiple
> > instances while dropping most of the code in favor of the generic
> > MMIO GPIO driver.
> >
> > As the driver now depend on CONFIG_GPIO_GENERIC also add a Kconfig
> > entry to make the driver optional.
> >
> > Signed-off-by: Alban Bedel <[email protected]>
>
> This patch looks nice but sadly does not apply to my "devel" branch in
> the GPIO tree:
> https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel
>
> Please rebase it on this branch or wait until after the merge window.
I see that you applied my previous patch "gpio: ath79: Convert to the
state container design pattern", this series was supposed to replace
this patch. I'm sorry I forgot to mention this. That old patch doesn't
make much sense any more as most of the code it changed just get
dropped in the move to GPIO_GENERIC.
> > +config GPIO_ATH79
> > + tristate "Atheros AR71XX/AR724X/AR913X GPIO support"
> > + default y if ATH79
> > + depends on ATH79 || COMPILE_TEST
>
> I think the build robot is complaining because of COMPILE_TEST. This
> driver doesn't really compile on anything else than ATH79 does it?
> Noone else has asm/mach-ath79/ar71xx_regs.h
>
> So I suggest dropping the compile test until this is fixed (e.g. by
> moving the GPIO register offsets into the driver, what do I know).
I'm going to split the compile test support to a separate patch.
Alban
On Sun, Nov 1, 2015 at 6:46 PM, Alban <[email protected]> wrote:
> On Sat, 31 Oct 2015 22:02:53 +0100
> Linus Walleij <[email protected]> wrote:
>> Please rebase it on this branch or wait until after the merge window.
>
> I see that you applied my previous patch "gpio: ath79: Convert to the
> state container design pattern", this series was supposed to replace
> this patch. I'm sorry I forgot to mention this. That old patch doesn't
> make much sense any more as most of the code it changed just get
> dropped in the move to GPIO_GENERIC.
Hm you can tell me exactly which commits I need to revert
or something ... I cannot rebase the tree now.
It would be best if you cook a GPIO_GENERIC patch based on
devel.
Yours,
Linus Walleij