2018-08-25 08:49:35

by Robert Jarzmik

Subject: [PATCH] gpio: pxa: handle corner case of unprobed device

In the corner case where the gpio driver probe fails, for whatever
reason, the suspend and resume handlers will still be called as they
have to be registered as syscore operations. This applies as well when
no probe was called while the driver has been built in the kernel.

Nicolas tracked this in :
https://bugzilla.kernel.org/show_bug.cgi?id=200905

Therefore, add a failsafe in these function, and test if a proper probe
succeeded and the driver is functional.

Signed-off-by: Robert Jarzmik <[email protected]>
Reported-by: Nicolas Chauvet <[email protected]>
---
drivers/gpio/gpio-pxa.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index c18712dabf93..bfe4c5c9f41c 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -776,6 +776,9 @@ static int pxa_gpio_suspend(void)
struct pxa_gpio_bank *c;
int gpio;

+ if (!pchip)
+ return 0;
+
for_each_gpio_bank(gpio, c, pchip) {
c->saved_gplr = readl_relaxed(c->regbase + GPLR_OFFSET);
c->saved_gpdr = readl_relaxed(c->regbase + GPDR_OFFSET);
@@ -794,6 +797,9 @@ static void pxa_gpio_resume(void)
struct pxa_gpio_bank *c;
int gpio;

+ if (!pchip)
+ return;
+
for_each_gpio_bank(gpio, c, pchip) {
/* restore level with set/clear */
writel_relaxed(c->saved_gplr, c->regbase + GPSR_OFFSET);
--
2.11.0

2018-08-29 11:58:42

by Linus Walleij

Subject: Re: [PATCH] gpio: pxa: handle corner case of unprobed device

On Sat, Aug 25, 2018 at 10:44 AM Robert Jarzmik <[email protected]> wrote:

> In the corner case where the gpio driver probe fails, for whatever
> reason, the suspend and resume handlers will still be called as they
> have to be registered as syscore operations. This applies as well when
> no probe was called while the driver has been built in the kernel.
>
> Nicolas tracked this in :
> https://bugzilla.kernel.org/show_bug.cgi?id=200905
>
> Therefore, add a failsafe in these function, and test if a proper probe
> succeeded and the driver is functional.
>
> Signed-off-by: Robert Jarzmik <[email protected]>
> Reported-by: Nicolas Chauvet <[email protected]>

Patch applied.

Yours,
Linus Walleij