2018-08-08 06:24:32

by jianchao.wang

Subject: [PATCH] scsi: use blk_mq_run_hw_queues in scsi_kick_queue

We don't use blk-mq start/stop hw queue any more, so no reason to
use blk_mq_start_hw_queues which does clear_bit, replace it with
blk_mq_run_hw_queues.

Signed-off-by: Jianchao Wang <[email protected]>
---
drivers/scsi/scsi_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 41e9ac9..7de0f26 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -371,7 +371,7 @@ void scsi_device_unbusy(struct scsi_device *sdev)
static void scsi_kick_queue(struct request_queue *q)
{
if (q->mq_ops)
- blk_mq_start_hw_queues(q);
+ blk_mq_run_hw_queues(q, false);
else
blk_run_queue(q);
}
--
2.7.4

2018-08-08 09:27:07

by Ming Lei

Subject: Re: [PATCH] scsi: use blk_mq_run_hw_queues in scsi_kick_queue

On Wed, Aug 8, 2018 at 2:24 PM, Jianchao Wang
<[email protected]> wrote:
> We don't use blk-mq start/stop hw queue any more, so no reason to
> use blk_mq_start_hw_queues which does clear_bit, replace it with
> blk_mq_run_hw_queues.
>
> Signed-off-by: Jianchao Wang <[email protected]>
> ---
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 41e9ac9..7de0f26 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -371,7 +371,7 @@ void scsi_device_unbusy(struct scsi_device *sdev)
> static void scsi_kick_queue(struct request_queue *q)
> {
> if (q->mq_ops)
> - blk_mq_start_hw_queues(q);
> + blk_mq_run_hw_queues(q, false);
> else
> blk_run_queue(q);
> }

Reviewed-by: Ming Lei <[email protected]>


Thanks,
Ming Lei

2018-08-09 02:04:10

by Martin K. Petersen

Subject: Re: [PATCH] scsi: use blk_mq_run_hw_queues in scsi_kick_queue

Jianchao,

> We don't use blk-mq start/stop hw queue any more, so no reason to
> use blk_mq_start_hw_queues which does clear_bit, replace it with
> blk_mq_run_hw_queues.

Applied to 4.19/scsi-queue, thanks!

--
Martin K. Petersen Oracle Linux Engineering