2016-10-29 08:12:26

by Ming Lei

Subject: [PATCH 04/60] block: floppy: use bio_add_page()

Signed-off-by: Ming Lei <[email protected]>
---
drivers/block/floppy.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index cdc916a95137..999099d9509d 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -3807,11 +3807,6 @@ static int __floppy_read_block_0(struct block_device *bdev, int drive)
cbdata.drive = drive;

bio_init_with_vec_table(&bio, &bio_vec, 1);
- bio_vec.bv_page = page;
- bio_vec.bv_len = size;
- bio_vec.bv_offset = 0;
- bio.bi_vcnt = 1;
- bio.bi_iter.bi_size = size;
bio.bi_bdev = bdev;
bio.bi_iter.bi_sector = 0;
bio.bi_flags |= (1 << BIO_QUIET);
@@ -3819,6 +3814,8 @@ static int __floppy_read_block_0(struct block_device *bdev, int drive)
bio.bi_end_io = floppy_rb0_cb;
bio_set_op_attrs(&bio, REQ_OP_READ, 0);

+ bio_add_page(&bio, page, size, 0);
+
submit_bio(&bio);
process_fd_request();

--
2.7.4

2016-10-31 15:26:21

by Christoph Hellwig

Subject: Re: [PATCH 04/60] block: floppy: use bio_add_page()

Why not keep the bio_add_page in the same spot as direct assignments
were before?

2016-10-31 22:54:40

by Ming Lei

Subject: Re: [PATCH 04/60] block: floppy: use bio_add_page()

On Mon, Oct 31, 2016 at 11:26 PM, Christoph Hellwig <[email protected]> wrote:
> Why not keep the bio_add_page in the same spot as direct assignments
> were before?

I just want to put adding page after setting bi_bdev.

Thanks,
Ming Lei