2013-05-11 07:42:56

by Jingoo Han

Subject: [PATCH 1/2] ARM: dts: add DP clock reference to exynos5250 device tree

The transition to common clock happened; however, DP (Display Port)
clock node was not added. Thus, DP (Display Port) clock node should
be added to the device tree.

Signed-off-by: Jingoo Han <[email protected]>
---
Tested on Exynos5250

arch/arm/boot/dts/exynos5250.dtsi | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 9dfc6de..8b1f9b6 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -651,6 +651,8 @@
reg = <0x145b0000 0x1000>;
interrupts = <10 3>;
interrupt-parent = <&combiner>;
+ clocks = <&clock 342>;
+ clock-names = "dp";
#address-cells = <1>;
#size-cells = <0>;

--
1.7.2.5

2013-05-11 21:25:20

by Doug Anderson

Subject: Re: [PATCH 1/2] ARM: dts: add DP clock reference to exynos5250 device tree

Jingoo,

On Sat, May 11, 2013 at 12:42 AM, Jingoo Han <[email protected]> wrote:
> The transition to common clock happened; however, DP (Display Port)
> clock node was not added. Thus, DP (Display Port) clock node should
> be added to the device tree.
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---
> Tested on Exynos5250
>
> arch/arm/boot/dts/exynos5250.dtsi | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)

Clock number matches clock bindings for 5250 and clock name matches dp
driver, so this looks good.

Reviewed-by: Doug Anderson <[email protected]>

2013-06-05 11:25:29

by Kukjin Kim

Subject: RE: [PATCH 1/2] ARM: dts: add DP clock reference to exynos5250 device tree

Vikas Sajjan wrote:
>
> Hi Mr. Jingoo Han,
>
> On Sat, May 11, 2013 at 1:12 PM, Jingoo Han <[email protected]> wrote:
> The transition to common clock happened; however, DP (Display Port)
> clock node was not added. Thus, DP (Display Port) clock node should
> be added to the device tree.
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---
> Tested on Exynos5250
>
> ?arch/arm/boot/dts/exynos5250.dtsi | ? ?2 ++
> ?1 files changed, 2 insertions(+), 0 deletions(-)

[...]

> ?I have already sent similar patch on 8th May 2013.
>
> http://www.spinics.net/lists/linux-samsung-soc/msg18136.html

Vikas, please don't use html typed e-mail :-(

OK, I found Jingoo's ack on that.

Let me take that with Jingoo's ack and Doug's review tag.

Thanks.

- Kukjin