2022-04-26 09:13:19

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH v2] Input: cros-ec-keyb: Only register keyboard if rows/columns exist

Hi,

On Mon, Apr 25, 2022 at 2:07 PM Stephen Boyd <[email protected]> wrote:
>
> If the device is a detachable, we may still probe this device because
> there are some button switches, e.g. volume buttons and power buttons,
> registered by this driver. Let's allow the device node to be missing row
> and column device properties to indicate that the keyboard matrix
> shouldn't be registered. This removes an input device on Trogdor devices
> such as Wormdingler that don't have a matrix keyboard, but still have
> power and volume buttons. That helps userspace understand there isn't
> a keyboard present when the detachable keyboard is disconnected.
>
> Cc: Benson Leung <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: Douglas Anderson <[email protected]>
> Cc: Hsin-Yi Wang <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
>
> Changes from v1 (https://lore.kernel.org/r/[email protected]):
> * Use device_property_present
>
> drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
> 1 file changed, 9 insertions(+)

Reviewed-by: Douglas Anderson <[email protected]>