2022-11-28 22:44:13

by Matthias Kaehlcke

Subject: [PATCH 1/2] ASoC: qcom: lpass-sc7180: Drop unnecessary initialization in _resume()

The initialization of the variable 'ret' in sc7180_lpass_dev_resume()
is unnecessary, as it is always assigned a few lines below. Drop the
initialization.

Signed-off-by: Matthias Kaehlcke <[email protected]>
---

sound/soc/qcom/lpass-sc7180.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
index 9c3365ddc274..7a81e609727c 100644
--- a/sound/soc/qcom/lpass-sc7180.c
+++ b/sound/soc/qcom/lpass-sc7180.c
@@ -165,7 +165,7 @@ static int sc7180_lpass_exit(struct platform_device *pdev)

static int sc7180_lpass_dev_resume(struct device *dev)
{
- int ret = 0;
+ int ret;
struct lpass_data *drvdata = dev_get_drvdata(dev);

ret = clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks);
--
2.38.1.584.g0f3c55d4c2-goog

2022-11-28 22:51:06

by Doug Anderson

Subject: Re: [PATCH 1/2] ASoC: qcom: lpass-sc7180: Drop unnecessary initialization in _resume()

Hi,

On Mon, Nov 28, 2022 at 2:12 PM Matthias Kaehlcke <[email protected]> wrote:
>
> The initialization of the variable 'ret' in sc7180_lpass_dev_resume()
> is unnecessary, as it is always assigned a few lines below. Drop the
> initialization.
>
> Signed-off-by: Matthias Kaehlcke <[email protected]>
> ---
>
> sound/soc/qcom/lpass-sc7180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Not that this needs review, but FWIW:

Reviewed-by: Douglas Anderson <[email protected]>