2021-01-12 11:50:03

by Abaci Team

Subject: [PATCH] pinctrl: sprd: style: Simplify bool comparison

Fix the following coccicheck warning:
./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to
bool

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: YANG LI <[email protected]>
---
drivers/pinctrl/sprd/pinctrl-sprd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index 08dc193..dca7a50 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -687,7 +687,7 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id,
shift = INPUT_SCHMITT_SHIFT;
break;
case PIN_CONFIG_BIAS_PULL_UP:
- if (is_sleep_config == true) {
+ if (is_sleep_config) {
val |= SLEEP_PULL_UP;
mask = SLEEP_PULL_UP_MASK;
shift = SLEEP_PULL_UP_SHIFT;
--
1.8.3.1

2021-01-13 03:38:34

by Baolin Wang

Subject: Re: [PATCH] pinctrl: sprd: style: Simplify bool comparison

On Tue, Jan 12, 2021 at 4:28 PM YANG LI <[email protected]> wrote:
>
> Fix the following coccicheck warning:
> ./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to
> bool
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: YANG LI <[email protected]>

The subject line should be "pinctrl: sprd: Simplify xxx", otherwise
Reviewed-by: Baolin Wang <[email protected]>

> ---
> drivers/pinctrl/sprd/pinctrl-sprd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
> index 08dc193..dca7a50 100644
> --- a/drivers/pinctrl/sprd/pinctrl-sprd.c
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -687,7 +687,7 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id,
> shift = INPUT_SCHMITT_SHIFT;
> break;
> case PIN_CONFIG_BIAS_PULL_UP:
> - if (is_sleep_config == true) {
> + if (is_sleep_config) {
> val |= SLEEP_PULL_UP;
> mask = SLEEP_PULL_UP_MASK;
> shift = SLEEP_PULL_UP_SHIFT;
> --
> 1.8.3.1
>


--
Baolin Wang

2021-01-19 04:23:53

by Linus Walleij

Subject: Re: [PATCH] pinctrl: sprd: style: Simplify bool comparison

On Tue, Jan 12, 2021 at 9:28 AM YANG LI <[email protected]> wrote:

> Fix the following coccicheck warning:
> ./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to
> bool
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: YANG LI <[email protected]>

Patch applied, fixing subject as indicated by Baolin.

First fix I get from Alibabas robot :)

Yours,
Linus Walleij