2021-05-04 02:09:16

by Zou Wei

Subject: [PATCH -next] dmaengine: sprd: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/dma/sprd-dma.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 0ef5ca8..4357d23 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -1265,6 +1265,7 @@ static const struct of_device_id sprd_dma_match[] = {
{ .compatible = "sprd,sc9860-dma", },
{},
};
+MODULE_DEVICE_TABLE(of, sprd_dma_match);

static int __maybe_unused sprd_dma_runtime_suspend(struct device *dev)
{
--
2.6.2

2021-05-10 13:51:26

by Baolin Wang

Subject: Re: [PATCH -next] dmaengine: sprd: Add missing MODULE_DEVICE_TABLE

On Tue, May 4, 2021 at 10:06 AM Zou Wei <[email protected]> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Reviewed-by: Baolin Wang <[email protected]>

> ---
> drivers/dma/sprd-dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index 0ef5ca8..4357d23 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -1265,6 +1265,7 @@ static const struct of_device_id sprd_dma_match[] = {
> { .compatible = "sprd,sc9860-dma", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, sprd_dma_match);
>
> static int __maybe_unused sprd_dma_runtime_suspend(struct device *dev)
> {
> --
> 2.6.2
>


--
Baolin Wang

2021-05-10 14:19:59

by Vinod Koul

Subject: Re: [PATCH -next] dmaengine: sprd: Add missing MODULE_DEVICE_TABLE

On 04-05-21, 10:22, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Applied, thanks

--
~Vinod