On 17-04-2013 13:11, Eduardo Valentin wrote:
> Rui,
Looks like I forgot to add the lists on patch 00. Doing so..
>
> This is a series of patches to improve the code for cpu_cooling.
> Majority of these changes are actually kernel-doc updates, as
> they required to be revised. A part from these, there are some
> changes regarding code style and readiness.
>
> Some may complain that these are a matter of taste, indeed.
> But I tried to just be unbiased and just keep the changes related
> to kernel-doc and checkpatch.pl. After this series, theses
> tools should be generating decent output ;-).
>
> The remaining changes are actually a couple of fixes for defensive
> coding. A part from updating the MAINTAINERS entry to cover cpu_cooling.
>
> This series has been tested on TI OMAP4430, together with the
> thermal driver under staging tree.
>
> All these patches are based on current linux-next/master.
>
> They are also available here:
>
> All best,
>
> Eduardo Valentin (30):
> thermal: cpu_cooling: remove unused headers
> thermal: cpu_cooling: remove trailing white spaces
> thermal: cpu_cooling: fix kernel_doc for cpufreq_cooling_device
> thermal: cpu_cooling: use EXPORT_SYMBOL_GPL
> thermal: cpu_cooling: remove compiler warning
> thermal: cpu_cooling: standardize end of function
> thermal: cpu_cooling: fix kernel doc for is_cpufreq_valid
> thermal: cpu_cooling: add documentation for get_property
> thermal: cpu_cooling: standardize comment style
> thermal: cpu_cooling: align on open parenthesis
> thermal: cpu_cooling: remove trailing blank line
> thermal: cpu_cooling: document cpufreq_get_cooling_level
> thermal: cpu_cooling: remove checkpatch.pl warning
> thermal: cpu_cooling: improve documentation for get_cpu_frequency
> thermal: cpu_cooling: update documentation for cpufreq_apply_cooling
> thermal: cpu_cooling: update documentation for
> cpufreq_thermal_notifier
> thermal: cpu_cooling: update Kconfig entry
> thermal: cpu_cooling: alignment improvements
> thermal: cpu_cooling: update documentation for cpufreq_get_max_state
> thermal: cpu_cooling: update documentation for cpufreq_get_cur_state
> thermal: cpu_cooling: update documentation for cpufreq_set_cur_state
> thermal: cpu_cooling: update kernel-doc for cpufreq_cooling_register
> thermal: cpu_cooling: update kernel-doc comment for
> cpufreq_cooling_unregister
> thermal: cpu_cooling: use snprintf instead of sprintf
> thermal: cpu_cooling: remove not needed curl brackets
> thermal: cpu_cooling: remove unused symbols
> thermal: cpu_cooling: add needed header for cpu_cooling.h
> MAINTAINERS: update thermal entry by adding file cpu_cooling.h
> thermal: cpu_cooling: remove unused symbols on cpu_cooling.h
> thermal: cpu_cooling: improve line breaking
>
> MAINTAINERS | 1 +
> drivers/thermal/Kconfig | 5 +-
> drivers/thermal/cpu_cooling.c | 156 ++++++++++++++++++++++++++++++------------
> include/linux/cpu_cooling.h | 20 +++---
> 4 files changed, 125 insertions(+), 57 deletions(-)
>
Hi Eduardo,
I looked at your whole series and they certainly looks useful, so for
the entire series,
Acked-by: Amit Daniel Kachhap <[email protected]>
Thanks,
Amit Daniel Kachhap
On Thu, Apr 18, 2013 at 2:02 AM, Eduardo Valentin
<[email protected]> wrote:
> On 17-04-2013 13:11, Eduardo Valentin wrote:
>>
>> Rui,
>
>
>
> Looks like I forgot to add the lists on patch 00. Doing so..
>>
>>
>> This is a series of patches to improve the code for cpu_cooling.
>> Majority of these changes are actually kernel-doc updates, as
>> they required to be revised. A part from these, there are some
>> changes regarding code style and readiness.
>>
>> Some may complain that these are a matter of taste, indeed.
>> But I tried to just be unbiased and just keep the changes related
>> to kernel-doc and checkpatch.pl. After this series, theses
>> tools should be generating decent output ;-).
>>
>> The remaining changes are actually a couple of fixes for defensive
>> coding. A part from updating the MAINTAINERS entry to cover cpu_cooling.
>>
>> This series has been tested on TI OMAP4430, together with the
>> thermal driver under staging tree.
>>
>> All these patches are based on current linux-next/master.
>>
>> They are also available here:
>>
>> All best,
>>
>> Eduardo Valentin (30):
>> thermal: cpu_cooling: remove unused headers
>> thermal: cpu_cooling: remove trailing white spaces
>> thermal: cpu_cooling: fix kernel_doc for cpufreq_cooling_device
>> thermal: cpu_cooling: use EXPORT_SYMBOL_GPL
>> thermal: cpu_cooling: remove compiler warning
>> thermal: cpu_cooling: standardize end of function
>> thermal: cpu_cooling: fix kernel doc for is_cpufreq_valid
>> thermal: cpu_cooling: add documentation for get_property
>> thermal: cpu_cooling: standardize comment style
>> thermal: cpu_cooling: align on open parenthesis
>> thermal: cpu_cooling: remove trailing blank line
>> thermal: cpu_cooling: document cpufreq_get_cooling_level
>> thermal: cpu_cooling: remove checkpatch.pl warning
>> thermal: cpu_cooling: improve documentation for get_cpu_frequency
>> thermal: cpu_cooling: update documentation for cpufreq_apply_cooling
>> thermal: cpu_cooling: update documentation for
>> cpufreq_thermal_notifier
>> thermal: cpu_cooling: update Kconfig entry
>> thermal: cpu_cooling: alignment improvements
>> thermal: cpu_cooling: update documentation for cpufreq_get_max_state
>> thermal: cpu_cooling: update documentation for cpufreq_get_cur_state
>> thermal: cpu_cooling: update documentation for cpufreq_set_cur_state
>> thermal: cpu_cooling: update kernel-doc for cpufreq_cooling_register
>> thermal: cpu_cooling: update kernel-doc comment for
>> cpufreq_cooling_unregister
>> thermal: cpu_cooling: use snprintf instead of sprintf
>> thermal: cpu_cooling: remove not needed curl brackets
>> thermal: cpu_cooling: remove unused symbols
>> thermal: cpu_cooling: add needed header for cpu_cooling.h
>> MAINTAINERS: update thermal entry by adding file cpu_cooling.h
>> thermal: cpu_cooling: remove unused symbols on cpu_cooling.h
>> thermal: cpu_cooling: improve line breaking
>>
>> MAINTAINERS | 1 +
>> drivers/thermal/Kconfig | 5 +-
>> drivers/thermal/cpu_cooling.c | 156
>> ++++++++++++++++++++++++++++++------------
>> include/linux/cpu_cooling.h | 20 +++---
>> 4 files changed, 125 insertions(+), 57 deletions(-)
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Amit,
On 21-04-2013 22:34, amit daniel kachhap wrote:
> Hi Eduardo,
>
> I looked at your whole series and they certainly looks useful, so for
> the entire series,
> Acked-by: Amit Daniel Kachhap <[email protected]>
>
Ok, thanks.
Side note: Your Linaro email address is bouncing. Could you please send
a patch updating the files you have signed?
> Thanks,
> Amit Daniel Kachhap
>
> On Thu, Apr 18, 2013 at 2:02 AM, Eduardo Valentin
> <[email protected]> wrote:
>> On 17-04-2013 13:11, Eduardo Valentin wrote:
>>>
>>> Rui,
>>
>>
>>
>> Looks like I forgot to add the lists on patch 00. Doing so..
>>>
>>>
>>> This is a series of patches to improve the code for cpu_cooling.
>>> Majority of these changes are actually kernel-doc updates, as
>>> they required to be revised. A part from these, there are some
>>> changes regarding code style and readiness.
>>>
>>> Some may complain that these are a matter of taste, indeed.
>>> But I tried to just be unbiased and just keep the changes related
>>> to kernel-doc and checkpatch.pl. After this series, theses
>>> tools should be generating decent output ;-).
>>>
>>> The remaining changes are actually a couple of fixes for defensive
>>> coding. A part from updating the MAINTAINERS entry to cover cpu_cooling.
>>>
>>> This series has been tested on TI OMAP4430, together with the
>>> thermal driver under staging tree.
>>>
>>> All these patches are based on current linux-next/master.
>>>
>>> They are also available here:
>>>
>>> All best,
>>>
>>> Eduardo Valentin (30):
>>> thermal: cpu_cooling: remove unused headers
>>> thermal: cpu_cooling: remove trailing white spaces
>>> thermal: cpu_cooling: fix kernel_doc for cpufreq_cooling_device
>>> thermal: cpu_cooling: use EXPORT_SYMBOL_GPL
>>> thermal: cpu_cooling: remove compiler warning
>>> thermal: cpu_cooling: standardize end of function
>>> thermal: cpu_cooling: fix kernel doc for is_cpufreq_valid
>>> thermal: cpu_cooling: add documentation for get_property
>>> thermal: cpu_cooling: standardize comment style
>>> thermal: cpu_cooling: align on open parenthesis
>>> thermal: cpu_cooling: remove trailing blank line
>>> thermal: cpu_cooling: document cpufreq_get_cooling_level
>>> thermal: cpu_cooling: remove checkpatch.pl warning
>>> thermal: cpu_cooling: improve documentation for get_cpu_frequency
>>> thermal: cpu_cooling: update documentation for cpufreq_apply_cooling
>>> thermal: cpu_cooling: update documentation for
>>> cpufreq_thermal_notifier
>>> thermal: cpu_cooling: update Kconfig entry
>>> thermal: cpu_cooling: alignment improvements
>>> thermal: cpu_cooling: update documentation for cpufreq_get_max_state
>>> thermal: cpu_cooling: update documentation for cpufreq_get_cur_state
>>> thermal: cpu_cooling: update documentation for cpufreq_set_cur_state
>>> thermal: cpu_cooling: update kernel-doc for cpufreq_cooling_register
>>> thermal: cpu_cooling: update kernel-doc comment for
>>> cpufreq_cooling_unregister
>>> thermal: cpu_cooling: use snprintf instead of sprintf
>>> thermal: cpu_cooling: remove not needed curl brackets
>>> thermal: cpu_cooling: remove unused symbols
>>> thermal: cpu_cooling: add needed header for cpu_cooling.h
>>> MAINTAINERS: update thermal entry by adding file cpu_cooling.h
>>> thermal: cpu_cooling: remove unused symbols on cpu_cooling.h
>>> thermal: cpu_cooling: improve line breaking
>>>
>>> MAINTAINERS | 1 +
>>> drivers/thermal/Kconfig | 5 +-
>>> drivers/thermal/cpu_cooling.c | 156
>>> ++++++++++++++++++++++++++++++------------
>>> include/linux/cpu_cooling.h | 20 +++---
>>> 4 files changed, 125 insertions(+), 57 deletions(-)
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>