2020-03-26 18:29:00

by Enric Balletbo i Serra

Subject: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols

When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see
the following error.

ERROR: modpost: "mtk_mmsys_ddp_disconnect"
[drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
ERROR: modpost: "mtk_mmsys_ddp_connect"
[drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!

Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be
able to be used for other modules.

Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")
Reported-by: Anders Roxell <[email protected]>
Signed-off-by: Enric Balletbo i Serra <[email protected]>
---

drivers/soc/mediatek/mtk-mmsys.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index 32a92ec447c5..05e322c9c301 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev,
writel_relaxed(reg, config_regs + addr);
}
}
+EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect);

void mtk_mmsys_ddp_disconnect(struct device *dev,
enum mtk_ddp_comp_id cur,
@@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
writel_relaxed(reg, config_regs + addr);
}
}
+EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);

static int mtk_mmsys_probe(struct platform_device *pdev)
{
--
2.25.1

2020-03-27 07:19:56

by Anders Roxell

Subject: Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols

On Thu, 26 Mar 2020 at 19:27, Enric Balletbo i Serra
<[email protected]> wrote:
>
> When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see
> the following error.
>
> ERROR: modpost: "mtk_mmsys_ddp_disconnect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
> ERROR: modpost: "mtk_mmsys_ddp_connect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>
> Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be
> able to be used for other modules.
>
> Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")
> Reported-by: Anders Roxell <[email protected]>
> Signed-off-by: Enric Balletbo i Serra <[email protected]>

Tested-by: Anders Roxell <[email protected]>

Cheers,
Anders

> ---
>
> drivers/soc/mediatek/mtk-mmsys.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 32a92ec447c5..05e322c9c301 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect);
>
> void mtk_mmsys_ddp_disconnect(struct device *dev,
> enum mtk_ddp_comp_id cur,
> @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
>
> static int mtk_mmsys_probe(struct platform_device *pdev)
> {
> --
> 2.25.1
>

2020-03-27 14:23:24

by Chun-Kuang Hu

Subject: Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols

Hi, Enric:

Enric Balletbo i Serra <[email protected]> 於 2020年3月27日 週五 上午2:28寫道：
>
> When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see
> the following error.
>
> ERROR: modpost: "mtk_mmsys_ddp_disconnect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
> ERROR: modpost: "mtk_mmsys_ddp_connect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>
> Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be
> able to be used for other modules.
>

Reviewed-by: Chun-Kuang Hu <[email protected]>


> Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")
> Reported-by: Anders Roxell <[email protected]>
> Signed-off-by: Enric Balletbo i Serra <[email protected]>
> ---
>
> drivers/soc/mediatek/mtk-mmsys.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 32a92ec447c5..05e322c9c301 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect);
>
> void mtk_mmsys_ddp_disconnect(struct device *dev,
> enum mtk_ddp_comp_id cur,
> @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
>
> static int mtk_mmsys_probe(struct platform_device *pdev)
> {
> --
> 2.25.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

2020-03-27 17:04:54

by Matthias Brugger

Subject: Re: [PATCH] soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols

On 26/03/2020 19:27, Enric Balletbo i Serra wrote:
> When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see
> the following error.
>
> ERROR: modpost: "mtk_mmsys_ddp_disconnect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
> ERROR: modpost: "mtk_mmsys_ddp_connect"
> [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>
> Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be
> able to be used for other modules.
>
> Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")
> Reported-by: Anders Roxell <[email protected]>
> Signed-off-by: Enric Balletbo i Serra <[email protected]>

I squashed this into the old commit:
396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device")

And pushed it out to v5.6-next/soc

Thanks!

> ---
>
> drivers/soc/mediatek/mtk-mmsys.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 32a92ec447c5..05e322c9c301 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect);
>
> void mtk_mmsys_ddp_disconnect(struct device *dev,
> enum mtk_ddp_comp_id cur,
> @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
> writel_relaxed(reg, config_regs + addr);
> }
> }
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
>
> static int mtk_mmsys_probe(struct platform_device *pdev)
> {
>