2018-03-28 15:54:57

by Arnd Bergmann

Subject: [PATCH] amdkfd: always select MMU_NOTIFIER

Building amdkfd without MMU notifiers is broken:

In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type

This adds the missing 'select MMU_NOTIFIER' line to make it build
cleanly all the time.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
index ed2f06c9f346..5a26acb90e19 100644
--- a/drivers/gpu/drm/amd/amdkfd/Kconfig
+++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
@@ -4,6 +4,7 @@

config HSA_AMD
tristate "HSA kernel driver for AMD GPU devices"
+ select MMU_NOTIFIER
depends on DRM_AMDGPU && X86_64
imply AMD_IOMMU_V2
help
--
2.9.0

2018-03-28 16:15:15

by Christian König

Subject: Re: [PATCH] amdkfd: always select MMU_NOTIFIER

Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
> Building amdkfd without MMU notifiers is broken:
>
> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type
>
> This adds the missing 'select MMU_NOTIFIER' line to make it build
> cleanly all the time.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Christian König <[email protected]>, but I would wait
on what Felix says to that.

> ---
> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index ed2f06c9f346..5a26acb90e19 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -4,6 +4,7 @@
>
> config HSA_AMD
> tristate "HSA kernel driver for AMD GPU devices"
> + select MMU_NOTIFIER
> depends on DRM_AMDGPU && X86_64
> imply AMD_IOMMU_V2
> help

2018-04-19 10:57:50

by Anders Roxell

Subject: Re: [PATCH] amdkfd: always select MMU_NOTIFIER

On 28 March 2018 at 18:04, Christian König <[email protected]> wrote:
> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
>>
>> Building amdkfd without MMU notifiers is broken:
>>
>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier'
>> has incomplete type
>>
>> This adds the missing 'select MMU_NOTIFIER' line to make it build
>> cleanly all the time.
>>
>> Signed-off-by: Arnd Bergmann <[email protected]>
>
>
> Acked-by: Christian König <[email protected]>, but I would wait on
> what Felix says to that.

Tested-by: Anders Roxell <[email protected]>

Randy sent the same patch [1] and its still required.

Cheers,
Anders
[1] https://patchwork.kernel.org/patch/10340885/

>
>
>> ---
>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig
>> b/drivers/gpu/drm/amd/amdkfd/Kconfig
>> index ed2f06c9f346..5a26acb90e19 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
>> @@ -4,6 +4,7 @@
>> config HSA_AMD
>> tristate "HSA kernel driver for AMD GPU devices"
>> + select MMU_NOTIFIER
>> depends on DRM_AMDGPU && X86_64
>> imply AMD_IOMMU_V2
>> help
>
>

2018-04-19 17:48:56

by Felix Kuehling

Subject: Re: [PATCH] amdkfd: always select MMU_NOTIFIER

On 2018-04-19 06:56 AM, Anders Roxell wrote:
> On 28 March 2018 at 18:04, Christian König <[email protected]> wrote:
>> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
>>> Building amdkfd without MMU notifiers is broken:
>>>
>>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
>>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier'
>>> has incomplete type
>>>
>>> This adds the missing 'select MMU_NOTIFIER' line to make it build
>>> cleanly all the time.
>>>
>>> Signed-off-by: Arnd Bergmann <[email protected]>
>>
>> Acked-by: Christian König <[email protected]>, but I would wait on
>> what Felix says to that.
> Tested-by: Anders Roxell <[email protected]>
>
> Randy sent the same patch [1] and its still required.
>
> Cheers,
> Anders
> [1] https://patchwork.kernel.org/patch/10340885/
Yes, looks good. I think this probably broke when we relaxed the
dependency on iommuv2.

Reviewed-by: Felix Kuehling <[email protected]>

Regards,
  Felix


>
>>
>>> ---
>>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>> b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>> index ed2f06c9f346..5a26acb90e19 100644
>>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>> @@ -4,6 +4,7 @@
>>> config HSA_AMD
>>> tristate "HSA kernel driver for AMD GPU devices"
>>> + select MMU_NOTIFIER
>>> depends on DRM_AMDGPU && X86_64
>>> imply AMD_IOMMU_V2
>>> help
>>

2018-04-24 09:55:40

by Oded Gabbay

Subject: Re: [PATCH] amdkfd: always select MMU_NOTIFIER

Thanks, but I took Randy's patch as it was earlier in my email queue.

Oded

On Thu, Apr 19, 2018 at 8:47 PM, Felix Kuehling <[email protected]> wrote:
> On 2018-04-19 06:56 AM, Anders Roxell wrote:
>> On 28 March 2018 at 18:04, Christian König <[email protected]> wrote:
>>> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
>>>> Building amdkfd without MMU notifiers is broken:
>>>>
>>>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
>>>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier'
>>>> has incomplete type
>>>>
>>>> This adds the missing 'select MMU_NOTIFIER' line to make it build
>>>> cleanly all the time.
>>>>
>>>> Signed-off-by: Arnd Bergmann <[email protected]>
>>>
>>> Acked-by: Christian König <[email protected]>, but I would wait on
>>> what Felix says to that.
>> Tested-by: Anders Roxell <[email protected]>
>>
>> Randy sent the same patch [1] and its still required.
>>
>> Cheers,
>> Anders
>> [1] https://patchwork.kernel.org/patch/10340885/
> Yes, looks good. I think this probably broke when we relaxed the
> dependency on iommuv2.
>
> Reviewed-by: Felix Kuehling <[email protected]>
>
> Regards,
> Felix
>
>
>>
>>>
>>>> ---
>>>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> index ed2f06c9f346..5a26acb90e19 100644
>>>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> @@ -4,6 +4,7 @@
>>>> config HSA_AMD
>>>> tristate "HSA kernel driver for AMD GPU devices"
>>>> + select MMU_NOTIFIER
>>>> depends on DRM_AMDGPU && X86_64
>>>> imply AMD_IOMMU_V2
>>>> help
>>>
>