2020-03-24 12:55:25

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] dma-buf: Improve CONFIG_DMABUF_MOVE_NOTIFY help text

Improve the help text for the CONFIG_DMABUF_MOVE_NOTIFY symbol by:
1. Removing duplicated single quotes,
2. Adding a missing subject,
3. Fixing a misspelling of "yet",
4. Wrapping long lines.

Fixes: bb42df4662a44765 ("dma-buf: add dynamic DMA-buf handling v15")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/dma-buf/Kconfig | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
index ef73b678419c6d86..9626673f1d83ae64 100644
--- a/drivers/dma-buf/Kconfig
+++ b/drivers/dma-buf/Kconfig
@@ -43,11 +43,12 @@ config DMABUF_MOVE_NOTIFY
bool "Move notify between drivers (EXPERIMENTAL)"
default n
help
- Don''t pin buffers if the dynamic DMA-buf interface is available on both the
- exporter as well as the importer. This fixes a security problem where
- userspace is able to pin unrestricted amounts of memory through DMA-buf.
- But marked experimental because we don''t jet have a consistent execution
- context and memory management between drivers.
+ Don't pin buffers if the dynamic DMA-buf interface is available on
+ both the exporter as well as the importer. This fixes a security
+ problem where userspace is able to pin unrestricted amounts of memory
+ through DMA-buf.
+ This is marked experimental because we don't yet have a consistent
+ execution context and memory management between drivers.

config DMABUF_SELFTESTS
tristate "Selftests for the dma-buf interfaces"
--
2.17.1


2020-03-25 18:44:38

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH] dma-buf: Improve CONFIG_DMABUF_MOVE_NOTIFY help text

On Tue, Mar 24, 2020 at 8:54 AM Geert Uytterhoeven
<[email protected]> wrote:
>
> Improve the help text for the CONFIG_DMABUF_MOVE_NOTIFY symbol by:
> 1. Removing duplicated single quotes,
> 2. Adding a missing subject,
> 3. Fixing a misspelling of "yet",
> 4. Wrapping long lines.
>
> Fixes: bb42df4662a44765 ("dma-buf: add dynamic DMA-buf handling v15")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Applied. Thanks!

Alex

> ---
> drivers/dma-buf/Kconfig | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index ef73b678419c6d86..9626673f1d83ae64 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -43,11 +43,12 @@ config DMABUF_MOVE_NOTIFY
> bool "Move notify between drivers (EXPERIMENTAL)"
> default n
> help
> - Don''t pin buffers if the dynamic DMA-buf interface is available on both the
> - exporter as well as the importer. This fixes a security problem where
> - userspace is able to pin unrestricted amounts of memory through DMA-buf.
> - But marked experimental because we don''t jet have a consistent execution
> - context and memory management between drivers.
> + Don't pin buffers if the dynamic DMA-buf interface is available on
> + both the exporter as well as the importer. This fixes a security
> + problem where userspace is able to pin unrestricted amounts of memory
> + through DMA-buf.
> + This is marked experimental because we don't yet have a consistent
> + execution context and memory management between drivers.
>
> config DMABUF_SELFTESTS
> tristate "Selftests for the dma-buf interfaces"
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel