2020-10-24 02:13:08

by Rasmus Villemoes

Subject: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read

Keep sparse happy by preserving the __user annotation when casting.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Rasmus Villemoes <[email protected]>
---

kernel test robot has already started spamming me due to 9c5743dff. If
I don't fix those warnings I'll keep getting those emails for
months, so let me do the easy ones.


drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
value = RREG32(RADEON_MM_DATA);
spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);

- r = put_user(value, (uint32_t *)buf);
+ r = put_user(value, (uint32_t __user *)buf);
if (r)
return r;

--
2.23.0

2021-04-01 18:13:45

by Christian König

Subject: Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read

Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> Keep sparse happy by preserving the __user annotation when casting.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Rasmus Villemoes <[email protected]>

Reviewed-by: Christian König <[email protected]>

Going over old patches and stumbled over that once.

Alex did you missed to pick it up?

Regards,
Christian.

> ---
>
> kernel test robot has already started spamming me due to 9c5743dff. If
> I don't fix those warnings I'll keep getting those emails for
> months, so let me do the easy ones.
>
>
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
> value = RREG32(RADEON_MM_DATA);
> spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
>
> - r = put_user(value, (uint32_t *)buf);
> + r = put_user(value, (uint32_t __user *)buf);
> if (r)
> return r;
>

2021-04-01 21:16:34

by Alex Deucher

Subject: Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read

Current code already contains the fix.

Alex


On Thu, Apr 1, 2021 at 9:09 AM Christian König
<[email protected]> wrote:
>
> Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> > Keep sparse happy by preserving the __user annotation when casting.
> >
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Rasmus Villemoes <[email protected]>
>
> Reviewed-by: Christian König <[email protected]>
>
> Going over old patches and stumbled over that once.
>
> Alex did you missed to pick it up?
>
> Regards,
> Christian.
>
> > ---
> >
> > kernel test robot has already started spamming me due to 9c5743dff. If
> > I don't fix those warnings I'll keep getting those emails for
> > months, so let me do the easy ones.
> >
> >
> > drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
> > value = RREG32(RADEON_MM_DATA);
> > spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
> >
> > - r = put_user(value, (uint32_t *)buf);
> > + r = put_user(value, (uint32_t __user *)buf);
> > if (r)
> > return r;
> >
>
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx