2020-10-15 23:21:54

by Sibi Sankar

Subject: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region

The modem firmware memory requirements vary between 32M/140M on
no-lte/lte skus respectively, so fixup the modem memory region
to reflect the requirements.

Signed-off-by: Sibi Sankar <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 4 ++++
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
index 44956e3165a1..469aad4e5948 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
@@ -9,6 +9,10 @@
label = "proximity-wifi-lte";
};

+&mpss_mem {
+ reg = <0x0 0x86000000 0x0 0x8c00000>;
+};
+
&remoteproc_mpss {
firmware-name = "qcom/sc7180-trogdor/modem/mba.mbn",
"qcom/sc7180-trogdor/modem/qdsp6sw.mbn";
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index bf875589d364..92a1fe114da8 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -39,7 +39,7 @@
};

mpss_mem: memory@86000000 {
- reg = <0x0 0x86000000 0x0 0x8c00000>;
+ reg = <0x0 0x86000000 0x0 0x2000000>;
no-map;
};

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-10-21 17:01:02

by Evan Green

Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region

On Thu, Oct 15, 2020 at 11:28 AM Sibi Sankar <[email protected]> wrote:
>
> The modem firmware memory requirements vary between 32M/140M on
> no-lte/lte skus respectively, so fixup the modem memory region
> to reflect the requirements.
>
> Signed-off-by: Sibi Sankar <[email protected]>

Reviewed-by: Evan Green <[email protected]>

2020-11-09 19:21:01

by Evan Green

Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region

On Tue, Oct 20, 2020 at 11:37 AM Evan Green <[email protected]> wrote:
>
> On Thu, Oct 15, 2020 at 11:28 AM Sibi Sankar <[email protected]> wrote:
> >
> > The modem firmware memory requirements vary between 32M/140M on
> > no-lte/lte skus respectively, so fixup the modem memory region
> > to reflect the requirements.
> >
> > Signed-off-by: Sibi Sankar <[email protected]>
>
> Reviewed-by: Evan Green <[email protected]>

Did this land anywhere?

2020-11-11 04:42:13

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region

On Mon 09 Nov 13:18 CST 2020, Evan Green wrote:

> On Tue, Oct 20, 2020 at 11:37 AM Evan Green <[email protected]> wrote:
> >
> > On Thu, Oct 15, 2020 at 11:28 AM Sibi Sankar <[email protected]> wrote:
> > >
> > > The modem firmware memory requirements vary between 32M/140M on
> > > no-lte/lte skus respectively, so fixup the modem memory region
> > > to reflect the requirements.
> > >
> > > Signed-off-by: Sibi Sankar <[email protected]>
> >
> > Reviewed-by: Evan Green <[email protected]>
>
> Did this land anywhere?

Doesn't look like it, so I've picked it now. Thanks for the bump.

Regards,
Bjorn