2021-07-20 10:17:00

by Sibi Sankar

Subject: [PATCH v2 08/10] arm64: dts: qcom: sc7280: Add nodes to boot modem

Add miscellaneous nodes to boot the modem and support post-mortem debug
on SC7280 SoCs.

Signed-off-by: Sibi Sankar <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 5ed7a511bfc9..3fb6a6ef39f8 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -547,6 +547,11 @@
#hwlock-cells = <1>;
};

+ tcsr_regs: syscon@1fc0000 {
+ compatible = "syscon";
+ reg = <0 0x01fc0000 0 0x30000>;
+ };
+
lpasscc: lpasscc@3000000 {
compatible = "qcom,sc7280-lpasscc";
reg = <0 0x03000000 0 0x40>,
@@ -1219,6 +1224,21 @@
};
};

+ imem@146aa000 {
+ compatible = "syscon", "simple-mfd";
+ reg = <0 0x146aa000 0 0x2000>;
+
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ ranges = <0 0x0 0 0x146aa000 0 0x2000>;
+
+ pil-reloc@94c {
+ compatible = "qcom,pil-reloc-info";
+ reg = <0 0x94c 0 0xc8>;
+ };
+ };
+
apps_smmu: iommu@15000000 {
compatible = "qcom,sc7280-smmu-500", "arm,mmu-500";
reg = <0 0x15000000 0 0x100000>;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2021-07-21 05:47:34

by Stephen Boyd

Subject: Re: [PATCH v2 08/10] arm64: dts: qcom: sc7280: Add nodes to boot modem

Quoting Sibi Sankar (2021-07-20 03:12:58)
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 5ed7a511bfc9..3fb6a6ef39f8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -1219,6 +1224,21 @@
> };
> };
>
> + imem@146aa000 {

is sram a more appropriate node name here? Is imem a generic node name
in DT spec?

> + compatible = "syscon", "simple-mfd";
> + reg = <0 0x146aa000 0 0x2000>;
> +
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + ranges = <0 0x0 0 0x146aa000 0 0x2000>;
> +
> + pil-reloc@94c {
> + compatible = "qcom,pil-reloc-info";
> + reg = <0 0x94c 0 0xc8>;
> + };
> + };
> +

2021-07-21 21:09:50

by Sibi Sankar

Subject: Re: [PATCH v2 08/10] arm64: dts: qcom: sc7280: Add nodes to boot modem

On 2021-07-21 11:14, Stephen Boyd wrote:
> Quoting Sibi Sankar (2021-07-20 03:12:58)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 5ed7a511bfc9..3fb6a6ef39f8 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -1219,6 +1224,21 @@
>> };
>> };
>>
>> + imem@146aa000 {
>
> is sram a more appropriate node name here? Is imem a generic node name
> in DT spec?

binding check for qcom,pil-info.yaml
didn't complain so I just followed
it. AFAICS, sram isn't mentioned in
generic node names either.

>
>> + compatible = "syscon", "simple-mfd";
>> + reg = <0 0x146aa000 0 0x2000>;
>> +
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + ranges = <0 0x0 0 0x146aa000 0 0x2000>;
>> +
>> + pil-reloc@94c {
>> + compatible = "qcom,pil-reloc-info";
>> + reg = <0 0x94c 0 0xc8>;
>> + };
>> + };
>> +

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.