On Tue, Jul 30, 2019 at 11:02 AM Nicolin Chen <[email protected]> wrote:
>
> On Sun, Jul 28, 2019 at 10:24:29PM +0300, Daniel Baluta wrote:
> > For i.MX7ULP and i.MX8MQ register map is changed. Add two new compatbile
> > strings to differentiate this.
> >
> > Signed-off-by: Daniel Baluta <[email protected]>
> > ---
> > Documentation/devicetree/bindings/sound/fsl-sai.txt | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> > index 2b38036a4883..b008e9cfedc1 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt
> > +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> > @@ -8,7 +8,8 @@ codec/DSP interfaces.
> > Required properties:
> >
> > - compatible : Compatible list, contains "fsl,vf610-sai",
> > - "fsl,imx6sx-sai" or "fsl,imx6ul-sai"
> > + "fsl,imx6sx-sai", "fsl,imx6ul-sai",
> > + "fsl,imx7ulp-sai", "fsl,imx8mq-sai".
>
> A nit, could have that 'or' :)
I removed the 'or' on purpose because I don't want to move it
around each time we add a new compatible.
Anyhow, I can put it back if this is the convention.
On Tue, Jul 30, 2019 at 03:02:30PM +0300, Daniel Baluta wrote:
> I removed the 'or' on purpose because I don't want to move it
> around each time we add a new compatible.
> Anyhow, I can put it back if this is the convention.
You could convert to the YAML binding format and sidestep the problem a
different way!
On Tue, Jul 30, 2019 at 3:05 PM Mark Brown <[email protected]> wrote:
>
> On Tue, Jul 30, 2019 at 03:02:30PM +0300, Daniel Baluta wrote:
>
> > I removed the 'or' on purpose because I don't want to move it
> > around each time we add a new compatible.
>
> > Anyhow, I can put it back if this is the convention.
>
> You could convert to the YAML binding format and sidestep the problem a
> different way!
Someone needs to do that in the end, so will try to change to yaml
with the next version
of the patch series.